Re: [PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Alexandre Julliard]

Fabian Maurer <dark.shadow4(a)web.de> writes:
> processorArchitecture should not be empty string

I don't think that's correct for assemblies that can be imported. Note
that the processorArchitecture is fixed up when creating the fake dll,
so it doesn't end up empty in the resources.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Fabian Maurer]

> I don't think that's correct for assemblies that can be imported. Note
> that the processorArchitecture is fixed up when creating the fake dll,
> so it doesn't end up empty in the resources.

Oh, you mean dlls are handled differently? I just went by the manifest itself, 
I figured that when it's wrong in one place it would be wrong in the other, 
too.
If you can guarantee that the dlls get a proper resource, then never mind 
that.

Regards,
Fabian Maurer

[PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Alexandre Julliard]

Fabian Maurer <dark.shadow4(a)web.de> writes:
> > I don't think that's correct for assemblies that can be imported. Note
> > that the processorArchitecture is fixed up when creating the fake dll,
> > so it doesn't end up empty in the resources.
>
> Oh, you mean dlls are handled differently? I just went by the manifest itself, 
> I figured that when it's wrong in one place it would be wrong in the other, 
> too.
> If you can guarantee that the dlls get a proper resource, then never mind 
> that.

All the files get a proper resource when built for Wine. It's only an
issue when cross-compiling to a Windows binary, since the PE compiler
doesn't do the same magic.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Fabian Maurer]

> All the files get a proper resource when built for Wine. It's only an
> issue when cross-compiling to a Windows binary, since the PE compiler
> doesn't do the same magic.
> So, the dlls would be affected too, when cross-compiled? Or am I 
> misunderstanding something here?
> Well, we don't really need to have it work when cross-compiled, I just thought 
> it would be nice to have.

Regards,
Fabian Maurer

[PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Alexandre Julliard]

Fabian Maurer <dark.shadow4(a)web.de> writes:
> > All the files get a proper resource when built for Wine. It's only an
> > issue when cross-compiling to a Windows binary, since the PE compiler
> > doesn't do the same magic.
> > So, the dlls would be affected too, when cross-compiled? Or am I 
> > misunderstanding something here?

Yes, they would be affected too.
> Well, we don't really need to have it work when cross-compiled, I just thought 
> it would be nice to have.

Sure, but this would need a more complicated process. Using "*" is not
correct here.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 01/10] atl80: Fix processorArchitecture in manifest

[Fabian Maurer]

> Yes, they would be affected too.
> Sure, but this would need a more complicated process. Using "*" is not
> correct here.

I see, thanks for explaining.

Regards,
Fabian Maurer