Re: Fix to bug 25504 for gnutls based schannel
On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote:
#ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> +#include <gcrypt.h> +#include <pthread.h> +#include <errno.h> +GCRY_THREAD_OPTION_PTHREAD_IMPL;
You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.
You can place on the Tiffany cross necklace with most factors - possibly even sportswear, in the event you are placing on some thing decent for the gym. whether or not you are dressed cutting or are within your sexiest tiny dark gown for just about any evening http://www.thomasaboshop.com/thomas-sabo-jewelry.html thomas sabo jewelry out in town, this could possibly be the sort of necklace that will go nicely with most things. This necklace says the fact that wearer is easy however classy. She will not scrimp on exceptional jewellery but she will not go overboard attempting to overdecorate her body. The bottom collection is, no make any difference what http://www.thomasaboshop.com/thomas-sabo-charms.html thomas sabo charm club sort of outfit you are wearing, in the event you need a fast jewellery fix to provide you with that instant research of classiness not owning having to place loads of make-up in your face, this necklace could possibly be the method to accomplish it. It will not need you getting genuinely really dressed as a good http://www.thomasaboshop.com/thomas-sabo-chains.html thomas sabo chains offer as pull the research off, nor will you http://www.thomasaboshop.com/thomas-sabo-necklaces.html thomas sabo necklaces need to fit the necklace with an outfit color. And that is genuinely one of the most useful place about this sort of necklace - that it may be an effortless research to pull off, effortless to pull on, and allows one to select in your jewellery possibilities in seconds, http://www.thomasaboshop.com/thomas-sabo-online-shop.html thomas sabo providing you even more time to purpose for the sleep of your outfit or in your make-up. -- View this message in context: http://wine.1045685.n5.nabble.com/Re-Fix-to-bug-25504-for-gnutls-based-schan... Sent from the Wine - Devel mailing list archive at Nabble.com.
On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote:
On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote:
#ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> +#include <gcrypt.h> +#include <pthread.h> +#include <errno.h> +GCRY_THREAD_OPTION_PTHREAD_IMPL;
You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.
I also wonder why libgcrypt is now needed, where this dll is using libgnutls? Ciao, Marcus
On Mon, 2011-04-18 at 10:36 +0200, Marcus Meissner wrote:
On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote:
On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote:
#ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> +#include <gcrypt.h> +#include <pthread.h> +#include <errno.h> +GCRY_THREAD_OPTION_PTHREAD_IMPL;
You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.
I also wonder why libgcrypt is now needed, where this dll is using libgnutls?
Yes, if there's a way to set the locking functions via gnutls then we wouldn't need to load libgcrypt.
On Apr 18, 2011, at 3:46 AM, Hans Leidekker wrote:
On Mon, 2011-04-18 at 10:36 +0200, Marcus Meissner wrote:
On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote:
On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote:
#ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> +#include <gcrypt.h> +#include <pthread.h> +#include <errno.h> +GCRY_THREAD_OPTION_PTHREAD_IMPL;
You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.
I also wonder why libgcrypt is now needed, where this dll is using libgnutls?
Yes, if there's a way to set the locking functions via gnutls then we wouldn't need to load libgcrypt.
http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-app... Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS. Regards, Ken
On Mon, 2011-04-18 at 04:23 -0500, Ken Thomases wrote:
I also wonder why libgcrypt is now needed, where this dll is using libgnutls?
Yes, if there's a way to set the locking functions via gnutls then we wouldn't need to load libgcrypt.
http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-app...
Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS.
Yes, that seems to do what we need, but it must be a recent addition because it's missing here from libgnutls.so.26.14.12.
Hans Leidekker <hans(a)codeweavers.com> writes:
On Mon, 2011-04-18 at 04:23 -0500, Ken Thomases wrote:
http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-app...
Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS.
Yes, that seems to do what we need, but it must be a recent addition because it's missing here from libgnutls.so.26.14.12.
The default pthread functions should work fine though. This sounds like a gnutls bug. -- Alexandre Julliard julliard(a)winehq.org
participants (5)
-
Alexandre Julliard -
Hans Leidekker -
Ken Thomases -
Marcus Meissner -
tiaotiao