steam regressed?

[Dan Kegel]

Hmm.  I can't start steam anymore.  This worked until quite recently...?

[Reece Dunn]

On 24 March 2010 00:52, Dan Kegel <dank(a)kegel.com> wrote:
> Hmm.  I can't start steam anymore.  This worked until quite recently...?

What does running `git bisect` give as the faulty commit?

- Reece

[Edward Savage]

On Wed, Mar 24, 2010 at 11:57 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote:
> On 24 March 2010 00:52, Dan Kegel <dank(a)kegel.com> wrote:
> > Hmm.  I can't start steam anymore.  This worked until quite recently...?
>
> What does running `git bisect` give as the faulty commit?
>
> - Reece

There has been a major Steam update in the last few days but no
regression between 1.1.40-41 that I can see.  The Classic client and
Beta UI both function correctly for me.

[Dan Kegel]

On Tue, Mar 23, 2010 at 5:57 PM, Reece Dunn <msclrhd(a)googlemail.com> wrote:
> On 24 March 2010 00:52, Dan Kegel <dank(a)kegel.com> wrote:
> > Hmm.  I can't start steam anymore.  This worked until quite recently...?
>
> What does running `git bisect` give as the faulty commit?

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[e9dbd5bff85488417ea3e4f2d40f37efc1759e2e] wined3d: Don't change the
draw buffer in IWineD3DDeviceImpl_SetFrontBackBuffers().

That was

http://www.winehq.org/pipermail/wine-patches/2010-March/085891.html

Henri, could you have a look?
- Dan

[Charles Davis]

On 3/23/10 10:49 PM, Dan Kegel wrote:
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> Uhh... You're not done yet.

I would've thought you knew that! Apparently not.

Chip

[Dan Kegel]

On Tue, Mar 23, 2010 at 10:38 PM, Charles Davis <cdavis(a)mymail.mines.edu> wrote:
> On 3/23/10 10:49 PM, Dan Kegel wrote:
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > Uhh... You're not done yet.
>
> I would've thought you knew that! Apparently not.

Oh, foo.  OK, the real result is:


7b52c2fbed561ac381f63826bab97802d0070e46 is first bad commit
commit 7b52c2fbed561ac381f63826bab97802d0070e46
Author: Henri Verbeet <hverbeet(a)codeweavers.com>
Date:   Tue Mar 16 19:02:20 2010 +0100

    wined3d: Cleanup IWineD3DDeviceImpl_SetFrontBackBuffers().

:040000 040000 c613b52cd5768d667adc8d2b9e11b2c2f9c4c947
d0c134cd592a9bc91c1b2429cd2ca366376b8af7 M	dlls

[Edward Savage]

On Wed, Mar 24, 2010 at 4:57 PM, Dan Kegel <dank(a)kegel.com> wrote:
> On Tue, Mar 23, 2010 at 10:38 PM, Charles Davis <cdavis(a)mymail.mines.edu> wrote:
> > On 3/23/10 10:49 PM, Dan Kegel wrote:
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > > Uhh... You're not done yet.
> >
> > I would've thought you knew that! Apparently not.
>
> Oh, foo.  OK, the real result is:
>
> 7b52c2fbed561ac381f63826bab97802d0070e46 is first bad commit
> commit 7b52c2fbed561ac381f63826bab97802d0070e46
> Author: Henri Verbeet <hverbeet(a)codeweavers.com>
> Date:   Tue Mar 16 19:02:20 2010 +0100
>
>    wined3d: Cleanup IWineD3DDeviceImpl_SetFrontBackBuffers().
>
> :040000 040000 c613b52cd5768d667adc8d2b9e11b2c2f9c4c947
> d0c134cd592a9bc91c1b2429cd2ca366376b8af7 M      dlls

Extra information is that the crash is caused by IE6 attempting to
load Flash content.

Vanilla Steam installs aren't effected so use the new winetricks steam verb.

Workaround is to remove Flash:
http://download.macromedia.com/pub/flashplayer/current/uninstall_flash_playe...

[Henri Verbeet]

On 24 March 2010 06:57, Dan Kegel <dank(a)kegel.com> wrote:
> Oh, foo.  OK, the real result is:
>
> 7b52c2fbed561ac381f63826bab97802d0070e46 is first bad commit
> commit 7b52c2fbed561ac381f63826bab97802d0070e46
> Author: Henri Verbeet <hverbeet(a)codeweavers.com>
> Date:   Tue Mar 16 19:02:20 2010 +0100
>
>    wined3d: Cleanup IWineD3DDeviceImpl_SetFrontBackBuffers().
>
> :040000 040000 c613b52cd5768d667adc8d2b9e11b2c2f9c4c947
> d0c134cd592a9bc91c1b2429cd2ca366376b8af7 M      dlls

Still works for me. A proper bug report with a backtrace & log would
help, of course.