[PATCH v2] kernel32/tests: Add more debugger tests.
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/debugger.c | 478 ++++++++++++++++++++++++++++++++- 1 file changed, 464 insertions(+), 14 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54953 Your paranoid android. === wvistau64_he (32 bit report) === kernel32: debugger.c:1126: Test failed: dwDebugEventCode = -1 debugger.c:1128: Test failed: ContinueDebugEvent failed, last error 87. debugger.c:1131: Test failed: didn't get any child events (flag: 1). debugger.c:151: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtBBEC.tmp': read=0 debugger.c:1143: Test failed: Got 10958580 failures from child process. debugger.c:1091: Test failed: unexpected event pid === wvistau64_he (task log) === Task errors: The task timed out === wvistau64 (64 bit report) === kernel32: debugger.c:1417: Test failed: dwDebugEventCode = 1 === debian10 (32 bit report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2). === debian10 (32 bit French report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2). === debian10 (32 bit Japanese:Japan report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2). debugger: Timeout === debian10 (32 bit Chinese:China report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2). === debian10 (32 bit WoW report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2). === debian10 (64 bit WoW report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00439ef2).
On 7/31/19 1:44 PM, Marvin wrote:
=== wvistau64_he (32 bit report) ===
kernel32: debugger.c:1126: Test failed: dwDebugEventCode = -1 debugger.c:1128: Test failed: ContinueDebugEvent failed, last error 87. debugger.c:1131: Test failed: didn't get any child events (flag: 1). debugger.c:151: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtBBEC.tmp': read=0 debugger.c:1143: Test failed: Got 10958580 failures from child process. debugger.c:1091: Test failed: unexpected event pid
This is not related to the patch. It looks like we need to increase the timeout in existing tests. On slightly related note, I feel like Vista is overrepresented on TestBot. It's the least interesting Windows version. While XP is still interesting sometimes, I don't see any value in testing on Vista. Debugger tests are an example of a case where Vista seems to behave worse than any other Windows version (XP including) and it just adds extra useless work of working around its weirdness. I'd suggest to plan to get rid of Vista from TestBot. Currently, due to multiple locale VMs, it has the highest number of VMs. I think it would make more sense to have win10 in multiple locales instead. Jacek
On Wed, 31 Jul 2019, Jacek Caban wrote: [...]
debugger.c:1143: Test failed: Got 10958580 failures from child process. debugger.c:1091: Test failed: unexpected event pid
This is not related to the patch. It looks like we need to increase the timeout in existing tests.
Do you mean the 2 minutes test timeout? We really don't want the tests to take that long.
On slightly related note, I feel like Vista is overrepresented on TestBot. It's the least interesting Windows version. While XP is still interesting sometimes, I don't see any value in testing on Vista. Debugger tests are an example of a case where Vista seems to behave worse than any other Windows version (XP including) and it just adds extra useless work of working around its weirdness. I'd suggest to plan to get rid of Vista from TestBot. Currently, due to multiple locale VMs, it has the highest number of VMs.
I don't think that matters. For tests I would say the only results that matter are 0 test failures, and 1+ test failures. Running a test more times on a given platform would not change that, except for random failures which are probably random on any platform anyway. So if test failures on Vista are not important the only option is to not run the tests on that platform at all. If there's a general agreement that's what we want I have no objection.
I think it would make more sense to have win10 in multiple locales instead.
I thought that required a special Windows version but apparently not. So sure, I can add locales there. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.
On 8/2/19 12:14 PM, Francois Gouget wrote:
On Wed, 31 Jul 2019, Jacek Caban wrote: [...]
debugger.c:1143: Test failed: Got 10958580 failures from child process. debugger.c:1091: Test failed: unexpected event pid
This is not related to the patch. It looks like we need to increase the timeout in existing tests. Do you mean the 2 minutes test timeout? We really don't want the tests to take that long.
No, it's a timeout inside test code. I will take care of it.
On slightly related note, I feel like Vista is overrepresented on TestBot. It's the least interesting Windows version. While XP is still interesting sometimes, I don't see any value in testing on Vista. Debugger tests are an example of a case where Vista seems to behave worse than any other Windows version (XP including) and it just adds extra useless work of working around its weirdness. I'd suggest to plan to get rid of Vista from TestBot. Currently, due to multiple locale VMs, it has the highest number of VMs. I don't think that matters. For tests I would say the only results that matter are 0 test failures, and 1+ test failures. Running a test more times on a given platform would not change that, except for random failures which are probably random on any platform anyway.
Debugger tests are an example, where I had to add a work around for random failures seem to be Vista only (like, it sometimes creates a weird, superfluous thread in a random moment). Whenever possible, we'd like to fix random failures on interesting platforms. TestBot is currently more likely to reveal rare failures on Vista than on win10, which is opposite to bug priorities IMHO.
So if test failures on Vista are not important the only option is to not run the tests on that platform at all.
That would be my preference. I don't think it's urgent nor important, but I think it would be nice to steer in that direction (and, at very least, not add any more Vista VMs in the future). Thanks, Jacek
participants (3)
-
Francois Gouget -
Jacek Caban -
Marvin