Re: comctl32/listview: fix selection in ownerdata listview
On 2/21/2013 02:19, Daniel Jelinski wrote:
/* disable per item notifications on LVS_OWNERDATA style FIXME: single LVN_ODSTATECHANGED should be used */ bOldChange = infoPtr->bDoChangeNotify; - if (infoPtr->dwStyle & LVS_OWNERDATA) infoPtr->bDoChangeNotify = FALSE; + /*if (infoPtr->dwStyle & LVS_OWNERDATA) infoPtr->bDoChangeNotify = FALSE;*/
What's a problem in fixing this properly? This change could break something potentially, it was disabled for a purpose of fixing some real application as I remember.
Hello Nikolay, I didn't have time to write and test a proper fix yet, and I'm not sure when I will. I thought this hack may be better than what we have now. If you want to fix this, please do. If not, I'll get back to it later. Regards, Daniel 2013/2/21, Nikolay Sivov <nsivov(a)codeweavers.com>:
What's a problem in fixing this properly? This change could break something potentially, it was disabled for a purpose of fixing some real application as I remember.
On 2/21/2013 11:01, Daniel Jelinski wrote:
Hello Nikolay, I didn't have time to write and test a proper fix yet, and I'm not sure when I will. I thought this hack may be better than what we have now. Sure, I get it. The problem is that it's not a correct way to fix that. Such hack is ok to attach to a bug report to test with, but it shouldn't be committed. If you want to fix this, please do. If not, I'll get back to it later. I do not plan to look at this right now. Anyway thanks for looking at this code and fixing other things. Regards, Daniel
2013/2/21, Nikolay Sivov <nsivov(a)codeweavers.com>:
What's a problem in fixing this properly? This change could break something potentially, it was disabled for a purpose of fixing some real application as I remember.
participants (2)
-
Daniel Jelinski -
Nikolay Sivov