re: [1/2] wcmd/setshow_attrib: Moved from internal to external attrib.exe
March 31, 2010
10:08 a.m.
Welcome to wine development! Problems with your patch: - you forgot to add your test to rsrc.rc - you forgot to include an expected output file - don't change .h files in patches that don't need the changes Please submit just the tests first, make sure 'make test' runs your tests, and make sure the .exe produced by 'make crosstest' passes on winetestbot. You might want to send the next patch to me for review before posting to wine-patches; you'll probably run into several more gotchas that it'd be nice to have cleared up before you post again. - Dan
5838
Age (days ago)
5838
Last active (days ago)
0 comments
1 participants
participants (1)
-
Dan Kegel