Re: PATCH - Build wrc with MS_VC and PSDK

[Dmitry Timoshkov]

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote:
> Changelog:
> LanguageID Porting for WRC.
> +#if !defined(_MSC_VER) && defined(__GNUC__)
> +#ifndef __MINGW32__
> +    ,
> +    { LANG_BRETON,         SUBLANG_NEUTRAL,              1252 },
> +    { LANG_CORNISH,        SUBLANG_NEUTRAL,              1252 },
> +    { LANG_ESPERANTO,      SUBLANG_NEUTRAL,              1252 },
> +    { LANG_GAELIC,         SUBLANG_NEUTRAL,              1252 },
>      { LANG_WALON,          SUBLANG_NEUTRAL,              1252 },
>      { LANG_WELSH,          SUBLANG_NEUTRAL,              1252 }
> +#endif /* __MINGW32__ */
> +#endif /* !defined(_MSC_VER) && defined(__GNUC__) */
>  };

I'd suggest to leave all the LANG_xxx on their appropriate places and
instead of protecting them by ugly

#if !defined(_MSC_VER) && defined(__GNUC__)
#ifndef __MINGW32__

construct use simple

#ifdef LANG_BRETON
    { LANG_BRETON,         SUBLANG_NEUTRAL,              1252 },
#endif

etc.

-- 
Dmitry.