Re: oleaut32:VatCat fixes initialization and conformance test

July 19, 2006


      --- Benjamin Arai <me(a)benjaminarai.com>:
...
Changelog:
  - Helps address http://bugs.winehq.com/show_bug.cgi?id=3628
  - Addresses variant initialization and missing conformance test
    issues brought up by Qingdoa Daoo
  - Fixes VarCat conformance test failures exposed by Rob Shearman: 
    "oleaut32: Test the return value of VarCat in the tests."
A test may pass on Windows because it returned without any errors
(S_OK) but on Wine that same test can technically fail but be 
misinterpeted as a correct result in Wine if the expected error code
is returned. Temporary variants may be uninitialized before usage in 
specific cases causing unexpected results.
Your patch is hard to read without apply first. Could you also attach the two functions
you modified in your local tree ( not in patch form )


@@ -2523,8 +2566,8 @@ HRESULT WINAPI VarCat(LPVARIANT left, LP
                         rightvt == VT_UI2 || rightvt == VT_UI4 ||
                         rightvt == VT_I8 || rightvt == VT_UI8 ||
                         rightvt == VT_INT || rightvt == VT_UINT))
-                        return DISP_E_BADVARTYPE;
-                    return hres;
+                        return DISP_E_TYPEMISMATCH;
+                    return DISP_E_TYPEMISMATCH;

Why the two consecutive "return DISP_E_TYPEMISMATCH" ?



	

	
		
___________________________________________________________ 
Mp3疯狂搜-新歌热歌高速下
http://music.yahoo.com.cn/?source=mail_mailbox_footer

    

qingdoa daoo