Re: some other console fixes

[Marcus Meissner]

On Tue, Jan 01, 2002 at 05:47:26PM +0100, eric pouech wrote:
> as spotted by Marcus, but only half done, the fg & bg colors were
> inverted
> moreover, this patch also some initialisation problems in wineconsole

Oh, sorry for not fixing correctly.

Eric, I have also found following additional problems:

- The Apply button in the Propertysheet never gets enabled.
  It always stays grayed out. When I press [Ok], the changes do get active,
  but are not saved into the registry. Somehow the property sheet does not
  get noticed that values inside it have changed... I do not have a clue
  how that works.

- The default font is not fixed pitch. This is strange, since the font enum
  appears correct. I hardcoded the default font to Console, but this is 
  not a good solution. 
  Testing now appears to provide only correct fonts. Strange.

- IDA text display is slow, it does a lot of redraws all the time.

  I tried the following patch, which makes redraws async:

Index: user.c
===================================================================
RCS file: /home/wine/wine/programs/wineconsole/user.c,v
retrieving revision 1.4
diff -u -r1.4 user.c
--- user.c	2002/01/01 00:14:02	1.4
+++ user.c	2002/01/02 18:59:18
@@ -501,7 +501,9 @@
 	r.bottom = (bm - data->curcfg.win_pos.Y + 1) * data->curcfg.cell_height;
 	InvalidateRect(PRIVATE(data)->hWnd, &r, FALSE);
 	WCUSER_FillMemDC(data, tp, bm);
+	/* 
 	UpdateWindow(PRIVATE(data)->hWnd);
+	*/
     }
 }
 
  However, while the redraws do work, they are coming very late sometimes, 
  as if repaints do not appears frequently enough. Strange.

- Mouse presses should be sent as input events. If I get too annoyed I just
  can just implement it ;)

- wineconsole without arguments crashes:

  6 faulted at EIP=0x00000043, CR2=0x00000000, EAX 0x00000001
  EBX 0x401ed0bc, ECX 0x40596cec, EBP 0x40596e18
  EDI 0x00000000, ESP 0x002b:0x40596e08 FS 0x008f, pid 1189
  exception 0xc000001d at address 0x00000043, fs 8f, pid 1189 ()
  wine: Unhandled exception, starting debugger...
  err:seh:start_debugger Couldn't start debugger ((null)) (0)
  Read the Wine Developers Guide on how to set up winedbg or another debugger

Ciao, Marcus

some other console fixes

[eric pouech]

> - The Apply button in the Propertysheet never gets enabled.
>   It always stays grayed out. When I press [Ok], the changes do get active,
>   but are not saved into the registry. Somehow the property sheet does not
>   get noticed that values inside it have changed... I do not have a clue
>   how that works.
yes. I didn't enable the apply button (shame on me)
in fact, there are two sets of configuration options:
- the current and the default
- the current only applies to the current opened console, whereas the
default
  eventually gets saved into the registry
- the current configuration set is opened with the 'properties' item in
the menu
- the default configuration set is opened with the 'default' item in the
menu
- it's the way NT2000 console behaves... not very ergonomic I admit ;-)

> - The default font is not fixed pitch. This is strange, since the font enum
>   appears correct. I hardcoded the default font to Console, but this is
>   not a good solution.
>   Testing now appears to provide only correct fonts. Strange.
did you remove any entry from the registry before starting the testings
?

> - IDA text display is slow, it does a lot of redraws all the time.
> 
>   I tried the following patch, which makes redraws async:
I think there are two different issues:
- wineconsole redraws itself by entire row, which is slow, especially
when
  the program writes character by character. two optimizations could be
made here
	1/ implement partial row update
	2/ the wineconsole could 'compress' incoming messages (especially
	   updates), so that some operations could be factorized (like screen
	   blitting)
- painting operations. sometimes, it seems the input gets frozen, and
paint
  events are not generated until the mouse moves for example... this
goes down
  to internal message passing and I didn't have the guts to look into it
yet

> - Mouse presses should be sent as input events. If I get too annoyed I just
>   can just implement it ;)
if you want to ;-) however, mouse events must be handled with care. they
can
either mean mouse click events to be generated, but also copy area
selection
Windows NT2000 console provides a switch (through the hereabove
mentionned menu
to enable one or the other more...). it's even more ergonomic than
before ;-))

> - wineconsole without arguments crashes:
thanx. that's fixed.

A+
-- 
---------------
Eric Pouech (http://perso.wanadoo.fr/eric.pouech/)
"The future will be better tomorrow", Vice President Dan Quayle