Re: Fix crash in dsound test
How did this fail in windows. Since it doesn't crash with wine, wine is doing something wrong. Lets try to figure out what is wrong and correct wine to have the same behavior as windows or at least notify someone that something is wrong. Is anyone working on getting direct sound into the windows port of our regression tests? Francois Gouget wrote:
Changelog:
* dlls/dsound/tests/dsound.c
Francois Gouget <fgouget(a)codeweavers.com> Call IDirectSound::Initialize() as per MSDN before using the DirectSound object. Fixes a crash on Windows.
------------------------------------------------------------------------
Index: dlls/dsound/tests/dsound.c =================================================================== RCS file: /var/cvs/wine/dlls/dsound/tests/dsound.c,v retrieving revision 1.24 diff -u -r1.24 dsound.c --- dlls/dsound/tests/dsound.c 13 Jul 2004 23:35:09 -0000 1.24 +++ dlls/dsound/tests/dsound.c 16 Jul 2004 16:23:51 -0000 @@ -69,6 +69,9 @@ if (rc==DS_OK) IDirectSound8_Release(ds8);
+ rc=IDirectSound_Initialize(dso,NULL); + ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); + /* DSOUND: Error: Invalid caps buffer */ rc=IDirectSound_GetCaps(dso,0); ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc)); @@ -168,6 +171,9 @@ if (rc==DS_OK) IDirectSound8_Release(ds8);
+ rc=IDirectSound8_Initialize(dso,NULL); + ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); + /* DSOUND: Error: Invalid caps buffer */ rc=IDirectSound8_GetCaps(dso,0); ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc));
Robert Reif <reif(a)earthlink.net> writes:
How did this fail in windows. Since it doesn't crash with wine, wine is doing something wrong. Lets try to figure out what is wrong and correct wine to have the same behavior as windows or at least notify someone that something is wrong.
Is anyone working on getting direct sound into the windows port of our regression tests?
Francois Gouget wrote:
Changelog:
* dlls/dsound/tests/dsound.c
Francois Gouget <fgouget(a)codeweavers.com> Call IDirectSound::Initialize() as per MSDN before using the DirectSound object. Fixes a crash on Windows.
Hi Kevin, hi Paul, Can you (cross)build the directsound tests? My toolchain is far too old, but yours could cope. If it/they can, we should include them into winetest, although interactive testing would remain unavoidable. Hmm, maybe winetest should explicitly reset WINETEST_INTERACTIVE and the other variables... -- Feri.
On Mon, 19 Jul 2004, Ferenc Wagner wrote: [...]
Can you (cross)build the directsound tests? My toolchain is far too old, but yours could cope. If it/they can, we should include them into winetest, although interactive testing would remain unavoidable. Hmm, maybe winetest should explicitly reset WINETEST_INTERACTIVE and the other variables...
It should probably do so. But maybe it could also have an option to explicitly let you run a specific test in interactive mode? That way it's still a single executable to get all the up-to-date tests, but users can also do the interactive tests if they want. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont \xE9t\xE9 remplac\xE9s par de nouveaux.
Francois Gouget <fgouget(a)free.fr> writes:
On Mon, 19 Jul 2004, Ferenc Wagner wrote:
maybe winetest should explicitly reset WINETEST_INTERACTIVE and the other variables...
It should probably do so. But maybe it could also have an option to explicitly let you run a specific test in interactive mode?
Yeah, but that would be a not-so-smallish extension. Winetest's GUI is rather crude as it's mostly used from the winrash service in console mode. But of course it would be possible without major changes to present code. I'm tacking it to the end of my TODO. Due in the following months. :( -- Feri.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Monday 19 July 2004 12:50, Ferenc Wagner wrote:
Can you (cross)build the directsound tests?
Yes. http://www.astro.gla.ac.uk/users/paulm/wine/dsound_test-20040721.10-00.exe with md5sum of: 9ca9562675eb87f18f25a56c6c5a1341 dsound_test-20040721.10-00.exe HTH, Paul. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFA/4lC/9JwS78PA+kRAqKxAKC8xSKUkKE7tE5wQdbWDjmgEOQMuwCfVgLy PsBk0HWCIgJ3kJxxAlaA0MU= =egCL -----END PGP SIGNATURE-----
Paul Millar <paulm(a)astro.gla.ac.uk> writes:
On Monday 19 July 2004 12:50, Ferenc Wagner wrote:
Can you (cross)build the directsound tests?
FWIW, yes:
http://www.astro.gla.ac.uk/users/paulm/wine/dsound_test-20040721.10-00.exe
Fine, that works, even. :) What an interesting experience it is to hear variously-pitched 440 Hz sounds! The wonders of Doppler effect, I guess. Why not make the velocity such that the audible tones form a minor second for example? That way it really could be an interactive *test*... :] Back to the build: Paul, I can't see your winetest builds being used (allowing for the present outage). Do you know what the problem is? Those of Kevin are used for all the reports I checked, but he hasn't responded yet. I'll send a patch to include dsound in winetest, and we will see if he publishes anything... -- Thanks, Feri.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thursday 22 July 2004 11:23, Ferenc Wagner wrote:
Do you know what the problem is? Those of Kevin are used for all the reports I checked, but he hasn't responded yet. I'll send a patch to include dsound in winetest, and we will see if he publishes anything...
OK, mea crap. The crontab entry was commented out, so wasn't doing anything and wasn't generating any error messages. I've triggered todays build and uncommented the entry. Cheers, Paul. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFBCRdC/9JwS78PA+kRAgCEAKCzWqRlH6IVNtF8KbWforMHCUAeDwCgp0RU xZ0PeyZ/BvxMLgU9AIJTgtI= =+0Cy -----END PGP SIGNATURE-----
Hi Robert, Robert Reif wrote:
How did this fail in windows. Since it doesn't crash with wine, wine is doing something wrong. Lets try to figure out what is wrong and correct wine to have the same behavior as windows or at least notify someone that something is wrong.
Sorry, I should have added a DSERR_UNINITIALIZED error check. But I see your "dsound initialization patch" fixes this oversight and also the DirectSound problem in Wine. Thanks.
Is anyone working on getting direct sound into the windows port of our regression tests?
Well, I didn't work on this directly but I tried to get executables for testing on Windows. Once I grabbed the special 'Wine MinGW' libraries I was able to compile it fine with MinGW so that's one way. I also tried to compile it with VC6 on Windows but I had less luck with that. I also had problems compiling the test on Windows using VC6+latest Win32 SDK+DirectX9.0. But your "windows compile patch" fixed these problems. So I think there's no obstacle to putting the DirectSound tests in winetest. The only problem with this test is that it requires DirectX 9.0. It's annoying because: * it means we cannot test the behavior of older versions of DirectX. * DirectX 9.0 cannot be installed on some Windows platforms, notably Windows 95 and NT4. So it would be cool if the dependencies on DirectX 9 could be made 'soft'. -- Francois Gouget fgouget(a)codeweavers.com
participants (5)
-
Ferenc Wagner -
Francois Gouget -
Francois Gouget -
Paul Millar -
Robert Reif