Re: [PATCH 2/7] gdiplus: Initialize bitmap bits for reading in GdipBitmapLockBits when ImageFlagsReadOnly is specified

[Vincent Povirk]

This is very strange behavior. I think you at least need a comment
making it clear this is intentional, and some tests.

Your test in 7/7 isn't sufficient because it doesn't make it clear
that the bits are being converted. I think you should test that the
bitmap format is different from the one you use to lock, and add
another test with ImageLockModeUserInputBuf.

On Wed, Feb 8, 2017 at 9:56 AM, Piotr Caban <piotr(a)codeweavers.com> wrote:
> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>
> ---
>  dlls/gdiplus/image.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 2/7] gdiplus: Initialize bitmap bits for reading in GdipBitmapLockBits when ImageFlagsReadOnly is specified

[Piotr Caban]

Hi,

On 02/10/17 03:30, Vincent Povirk wrote:
> This is very strange behavior. I think you at least need a comment
> making it clear this is intentional, and some tests.
> It turns out this patch was incorrect. I've made wrong assumptions from 
> reading uninitialized memory.

Thanks,
Piotr