Re: REGRESSION: environment variables no longer possible
"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes:
Actually it's just the format of the Wine config has changed. Now all environment variables should be surrounded by the percent signes (%HOME%), and are handled by the normal registry code. Alexandre has changed the sample config as well.
Actually the format of the config has not really changed, most entries have been behaving that way for a long time already. I just made the drives part of the config behave like all the other entries.
Attached patch is rather useless, but however it makes the old profile code be consistent with the new behaviour. A better approach is to completely remove environment handling from profile.c.
Yes, I think environment handling should be left to the application. -- Alexandre Julliard julliard(a)winehq.com
On Tue, 19 Aug 2003, Alexandre Julliard wrote:
Attached patch is rather useless, but however it makes the old profile code be consistent with the new behaviour. A better approach is to completely remove environment handling from profile.c.
Yes, I think environment handling should be left to the application.
While this makes sense from a separation perspective, it will prove to be very inconvenient in practice. For decent integration we need access to the environment, and having wrapper over wrapper to do these things is not convenient. Maybe the solution would be to have a winecore things that does the absolute minimum, and have a wine be a wrapper that handles environment, etc. IIRC there are other candidates for moving in such a beast, no? -- Dimi.
"Dimitrie O. Paun" <dimi(a)intelliware.ca> writes:
While this makes sense from a separation perspective, it will prove to be very inconvenient in practice. For decent integration we need access to the environment, and having wrapper over wrapper to do these things is not convenient.
I don't see why it would be any different than running under Windows. If the app supports environment variables in its .ini file under Windows then it will support them under Wine, otherwise it won't. I don't think we should magically expand things in .ini files. Environment variables in the Wine config file itself are supported, as long as you use the Windows syntax. -- Alexandre Julliard julliard(a)winehq.com
On Tue, 19 Aug 2003, Alexandre Julliard wrote:
I don't see why it would be any different than running under Windows. If the app supports environment variables in its .ini file under Windows then it will support them under Wine, otherwise it won't. I don't think we should magically expand things in .ini files. Environment variables in the Wine config file itself are supported, as long as you use the Windows syntax.
Of course you are correct, I replyed before understanding the problem. I thought we were talking about the access of Windows apps to the Unix environment variables. -- Dimi.
On Tue, Aug 19, 2003 at 10:33:44AM -0700, Alexandre Julliard wrote:
"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes:
Actually it's just the format of the Wine config has changed. Now all environment variables should be surrounded by the percent signes (%HOME%), and are handled by the normal registry code. Alexandre has changed the sample config as well.
Actually the format of the config has not really changed, most entries have been behaving that way for a long time already. I just made the drives part of the config behave like all the other entries.
Small migration nightmare though. But then again, WINE is alpha software. Ciao, Marcus
Alexandre Julliard wrote:
"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes:
Actually it's just the format of the Wine config has changed. Now all environment variables should be surrounded by the percent signes (%HOME%), and are handled by the normal registry code. Alexandre has changed the sample config as well.
Actually the format of the config has not really changed, most entries have been behaving that way for a long time already. I just made the drives part of the config behave like all the other entries.
Attached patch is rather useless, but however it makes the old profile code be consistent with the new behaviour. A better approach is to completely remove environment handling from profile.c.
Yes, I think environment handling should be left to the application.
I (incendentally <g>) had the same patch in my tree that what Alexandre committed yesterday. I'll send the removal of env handling later on today. A+ -- Eric Pouech
participants (4)
-
Alexandre Julliard -
Dimitrie O. Paun -
Eric Pouech -
Marcus Meissner