Re: [PATCH 2/4] d3drm: Implement IDirect3DRMTexture{2-3}_InitFromImage.

[Sebastian Lackner]

On 28.04.2016 21:17, Aaryaman Vasishta wrote:
> +    IDirect3DRM_AddRef(texture->d3drm);
> +
> +    if (texture->image)
> +        return D3DRMERR_BADOBJECT;

Doesn't this leak a reference in case of an error? ->initialized is not
set to TRUE yet.

[PATCH 2/4] d3drm: Implement IDirect3DRMTexture{2-3}_InitFromImage.

[Aaryaman Vasishta]

It does, but that's how Native behaves too. See the tests on this patch for
more details.

Cheers,
Aaryaman

On Friday, April 29, 2016, Sebastian Lackner <sebastian(a)fds-team.de> wrote:
> On 28.04.2016 21:17, Aaryaman Vasishta wrote:
> > +    IDirect3DRM_AddRef(texture->d3drm);
> > +
> > +    if (texture->image)
> > +        return D3DRMERR_BADOBJECT;
>
> Doesn't this leak a reference in case of an error? ->initialized is not
> set to TRUE yet.