Re: [PATCH 1/2 v2] ntdll/tests: Check debug registers of a newly created thread

[Christian Inci]

Forgot to send the response to wine-devel too.

On 04/07/2017 10:01 PM, Christian Inci wrote:
> Thank you very much for letting me know.
>
> Setting Dr7 with the "wrong" bits set will result into this error.
> I'm going to change the testcase right now.
>
> On 04/07/2017 09:07 PM, Alexandre Julliard wrote:
> > Christian Inci <chris.wine(a)broke-the-inter.net> writes:
> > > +static void test_thread_debug_registers(void)
> > > +{
> > > +    HANDLE thread;
> > > +    CONTEXT ctx;
> > > +    NTSTATUS status;
> > > +
> > > +    ctx.ContextFlags = CONTEXT_DEBUG_REGISTERS;
> > > +    ctx.Dr0 = 0xffffffff;
> > > +    ctx.Dr1 = 0xffffffff;
> > > +    ctx.Dr2 = 0xffffffff;
> > > +    ctx.Dr3 = 0xffffffff;
> > > +    ctx.Dr6 = 0xffffffff;
> > > +    ctx.Dr7 = 0xffffffff;
> > > +    status = pNtSetContextThread(GetCurrentThread(), &ctx);
> > > +    todo_wine ok(status == STATUS_SUCCESS, "NtSetContextThread failed with %x\n", status);
> >
> > It would be a more convincing test if setting the context succeeded. The
> > failure is of course interesting too, but that could be a separate test.