Re: Use the new swapvp function
shell32 shelllink.c uses fork on line 748 and waitpid on line 789 Dimitrie O. Paun wrote:
As promissed...
Any other places that may need it?
ChangeLog Make use of the new swapvp function in wine{gcc,wrap}.
From prior discussion it seems like it should use CreateProcess but I was not really sure. I was going to attempt to fix some other unix and wineisms in shelllink.c and shellexec.c but I need a good test app or regression test for these functions. I guess I could try and write a test for it..... also that reminds me are you going to write any tests for comctl32? I can test/use comctl32 under Win2k but having a test suite rather the just a few apps would be nice. If you dont plan on doing any maybe myself and some of the ReactOS developers can write some as we are working on getting shell32 and comctl32 to work.
Thanks Steven
That one looks like it wants to use CreateProcess(), no?
-- Dimi.
__________________________________________________ Do you Yahoo!? Yahoo! Tax Center - File online, calculators, forms, and more http://tax.yahoo.com
On April 3, 2003 08:32 am, Steven Edwards wrote:
I can test/use comctl32 under Win2k but having a test suite rather the just a few apps would be nice. If you dont plan on doing any maybe myself and some of the ReactOS developers can write some as we are working on getting shell32 and comctl32 to work.
Yes, it would be nice to have such test, but unfortunately I afraid I don't have the time to do it. So any help in that area is very much appreciated. -- Dimi.
There's a patch in the Crossover tree that fixes that (or at least moves it), if you want to wait a couple of weeks... Mike Dimitrie O. Paun wrote:
On April 2, 2003 02:39 pm, Steven Edwards wrote:
shell32 shelllink.c uses fork on line 748 and waitpid on line 789
That one looks like it wants to use CreateProcess(), no?
Hmm, I'm curious, how do patches from CrossOver make their way back to WineHQ? Do you guys have a big patching session where it all goes through wine-patches, or do they get brought straight into CVS? thanks -mike On Thu, 2003-04-03 at 14:42, Mike McCormack wrote:
There's a patch in the Crossover tree that fixes that (or at least moves it), if you want to wait a couple of weeks...
Mike
Dimitrie O. Paun wrote:
On April 2, 2003 02:39 pm, Steven Edwards wrote:
shell32 shelllink.c uses fork on line 748 and waitpid on line 789
That one looks like it wants to use CreateProcess(), no?
On Fri, 2003-04-04 at 14:05, Mike Hearn wrote:
Hmm, I'm curious, how do patches from CrossOver make their way back to WineHQ? Do you guys have a big patching session where it all goes through wine-patches, or do they get brought straight into CVS?
Usually after we ship, Alexandre does a merge and then just commits them straight into CVS. Usually everything is in within 1-2 weeks of each release. Alexandre will also often take useful bits we've done between releases and merge them in, but that tends to be more of a case by case basis, and for things he sees a crying need for in the main WineHQ. Really, we do it just about as stealthily as we can, which our marketing department has issues with... Cheers, Jer
Mike Hearn <mike(a)theoretic.com> writes:
Hmm, I'm curious, how do patches from CrossOver make their way back to WineHQ? Do you guys have a big patching session where it all goes through wine-patches, or do they get brought straight into CVS?
The Codeweavers folks sometimes submit their patches to wine-patches directly, but usually they are happy to leave all the work to me ;-) What I do is that once a Crossover release is out I do a big WineHQ->Crossover merge, and then diff the trees and put the changes back into the WineHQ CVS. So the patches don't appear on wine-patches, but you can see them through wine-cvs. -- Alexandre Julliard julliard(a)winehq.com
participants (6)
-
Alexandre Julliard -
Dimitrie O. Paun -
Jeremy White -
Mike Hearn -
Mike McCormack -
Steven Edwards