Re: shlwapi: Update exported API entries according to the info published by Geoff Chappell
Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
@@ -1,18 +1,18 @@ -1 stdcall -noname ParseURLA(str ptr) -2 stdcall -noname ParseURLW(wstr ptr) +1 stdcall ParseURLA(str ptr) +2 stdcall ParseURLW(wstr ptr)
That doesn't look right, why are you removing -noname on these and many other functions? AFAICT they are not exported by name in most shlwapi versions. -- Alexandre Julliard julliard(a)winehq.org
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
@@ -1,18 +1,18 @@ -1 stdcall -noname ParseURLA(str ptr) -2 stdcall -noname ParseURLW(wstr ptr) +1 stdcall ParseURLA(str ptr) +2 stdcall ParseURLW(wstr ptr)
That doesn't look right, why are you removing -noname on these and many other functions? AFAICT they are not exported by name in most shlwapi versions.
I've removed -noname for entries that according to Geoff started to be exported by name in some Windows versions. We have some such entries already. -- Dmitry.
"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
I've removed -noname for entries that according to Geoff started to be exported by name in some Windows versions. We have some such entries already.
If the function was newly added in that version then it's OK, but if the function is available by ordinal in earlier versions then it has to be -noname for imports to work correctly. -- Alexandre Julliard julliard(a)winehq.org
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
I've removed -noname for entries that according to Geoff started to be exported by name in some Windows versions. We have some such entries already.
If the function was newly added in that version then it's OK, but if the function is available by ordinal in earlier versions then it has to be -noname for imports to work correctly.
That means that if/once apps start to import shlwapi APIs by name they will not work in Wine. Also, do you mean that APIs for which entries -noname has been already removed need to be fixed to have -noname again? -- Dmitry.
"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
That means that if/once apps start to import shlwapi APIs by name they will not work in Wine. Also, do you mean that APIs for which entries -noname has been already removed need to be fixed to have -noname again?
With -noname the name should still be available in the export table, but not be used for importing. And yes, if -noname has been removed from functions that are exported by ordinal in some versions that's wrong. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Dmitry Timoshkov