Re: [PATCH] comctl32: Update Thumb Rect when position changes

[Nikolay Sivov]

On 08.01.2016 10:33, Alistair Leslie-Hughes wrote:
> ---
>  dlls/comctl32/trackbar.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/comctl32/trackbar.c b/dlls/comctl32/trackbar.c
> index 6d092a3..3a92794 100644
> --- a/dlls/comctl32/trackbar.c
> +++ b/dlls/comctl32/trackbar.c
> @@ -1225,13 +1225,17 @@ TRACKBAR_SetPos (TRACKBAR_INFO *infoPtr, BOOL fPosition, LONG lPosition)
>      infoPtr->lPos = lPosition;
>
> if (infoPtr->lPos < infoPtr->lRangeMin)
> -	infoPtr->lPos = infoPtr->lRangeMin;
> +        infoPtr->lPos = infoPtr->lRangeMin;
>
> if (infoPtr->lPos > infoPtr->lRangeMax)
> -	infoPtr->lPos = infoPtr->lRangeMax;
> +        infoPtr->lPos = infoPtr->lRangeMax;
>      infoPtr->flags |= TB_THUMBPOSCHANGED;
>
> -    if (fPosition && oldPos != lPosition) TRACKBAR_InvalidateThumbMove(infoPtr, oldPos, lPosition);
> +    if (fPosition && oldPos != lPosition)
> +    {
> +        TRACKBAR_UpdateThumb(infoPtr);
> +        TRACKBAR_InvalidateThumbMove(infoPtr, oldPos, infoPtr->lPos);
> +    }
>
> return 0;
>  }

It's updated indirectly later I think. What does this fix? Visually
SETPOS works as it is for me.

[PATCH] comctl32: Update Thumb Rect when position changes

[Alistair Leslie-Hughes]

On 08/01/16 19:04, Nikolay Sivov wrote:
> On 08.01.2016 10:33, Alistair Leslie-Hughes wrote:
> >
>
> It's updated indirectly later I think. What does this fix? Visually
> SETPOS works as it is for me.

When a Dialog is loaded for the first time, with one of these controls, 
the thumb always appears at 0.  Yes should be updated indirectly but for 
the initial load these seems to be failing.

I've create an report with details on how to reproduce the issue.
https://bugs.winehq.org/show_bug.cgi?id=39952

Best Regards
  Alistair Leslie-Hughes