[AppDB] create new users is Br0ck.

The last patch broke make_bugzilla_version_list() which is used by account.php 
and admin/editAppVersion.php.  That means that new users can not create accounts 
and maintainers cannot edit their versions.

http://cvs.winehq.org/patch.py?id=15387

The same code on my machine works fine with my test databases.

I do not know how to fix this other than reversing the patch.

--

Tony Lambregts.

[Jonathan Ernst]

Le mardi 11 janvier 2005 à 21:25 -0700, tony_lambregts(a)telusplanet.net a
écrit :
> The last patch broke make_bugzilla_version_list() which is used by account.php 
> and admin/editAppVersion.php.  That means that new users can not create accounts 
> and maintainers cannot edit their versions.
>
> http://cvs.winehq.org/patch.py?id=15387
>
> The same code on my machine works fine with my test databases.
>
> I do not know how to fix this other than reversing the patch.
>
> --
>
> Tony Lambregts.

May I see the error message ? (I'm no admin so I cannot activate debug
mode on the live server).

[Paul van Schayck]

Hey,

I'm not entirely sure what's going wrong here either. I don't see any
functional change except from a mysql_connect() to a pconnect(). Which
shouldn't make a difference. After setting up the bugzilla tables and
include/config.php it worked for me. Weird...

I saw a patch from Jonathan tough changing to normal connects so that
might fix it altough I doubt it.

Paul

[Jonathan Ernst]

Le mercredi 12 janvier 2005 à 16:40 +0100, Paul van Schayck a écrit :
> Hey,
>
> I'm not entirely sure what's going wrong here either. I don't see any
> functional change except from a mysql_connect() to a pconnect(). Which
> shouldn't make a difference. After setting up the bugzilla tables and
> include/config.php it worked for me. Weird...
>
> I saw a patch from Jonathan tough changing to normal connects so that
> might fix it altough I doubt it.
>
> Paul

I made a patch for it again as only one pconnect had been replaced when
Chris commited it (altough my patch contained both pconnect occurences
replacement). The remaining pconnect is in the bugzilla function and as
we think this function is the problem we will see if it changes
something or not (it would be weird in both cases).

[Tony Lambregts]

Jonathan Ernst wrote:
> Le mardi 11 janvier 2005 à 21:25 -0700, tony_lambregts(a)telusplanet.net a
> écrit :
> > The last patch broke make_bugzilla_version_list() which is used by account.php 
> > and admin/editAppVersion.php.  That means that new users can not create accounts 
> > and maintainers cannot edit their versions.
> >
> > http://cvs.winehq.org/patch.py?id=15387
> >
> > The same code on my machine works fine with my test databases.
> >
> > I do not know how to fix this other than reversing the patch.
> >
> > --
> >
> > Tony Lambregts.
>
> May I see the error message ? (I'm no admin so I cannot activate debug
> mode on the live server).

Go into an app that you own and try to edit it (or try to change your 
preferences) and will see the  problem. I cannot see any error mesages. (I am 
sure I had debug on in my preferences).

Jeremy or Chris could set it on globaly perhaps.

--

Tony Lambregts

[AppDB] Now User Preferences is Br0ck.

It seems that adding a new user now works and so does editing a version. So 
thats the good news. The bad news is that user preferences is still broken with 
Current CVS. It gets a little farther and display's the versions box, but I get 
the following error message on my system (line 35 of db.php is a blank line .. 
go figure)

Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 
68254 bytes) in /var/www/html/appdb/include/db.php on line 35

Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 
136 bytes) in Unknown on line 0

I am tying to test this out but it sure is not behaving right.

--

Tony Lambregts

[AppDB] Now User Preferences is Br0ck. (fix sort of?)

tony_lambregts(a)telusplanet.net wrote:
> It seems that adding a new user now works and so does editing a version. 
> So thats the good news. The bad news is that user preferences is still 
> broken with Current CVS. It gets a little farther and display's the 
> versions box, but I get the following error message on my system (line 
> 35 of db.php is a blank line .. go figure)
>
> Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to 
> allocate 68254 bytes) in /var/www/html/appdb/include/db.php on line 35
>
> Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to 
> allocate 136 bytes) in Unknown on line 0
>
> I am tying to test this out but it sure is not behaving right.
>
> --
>
> Tony Lambregts

This patch fixes it on my system. the wierd thing is that on my system I have.

define("APPS_DB","apidb");
and
define("USERS_DB","apidb");


So why would it make any difference?

Change Log: fix up user preferences screen.

Files changed: preferences.php include/db.php

Index: include/db.php
===================================================================
RCS file: /home/wine/appdb/include/db.php,v
retrieving revision 1.9
diff -u -r1.9 db.php
--- include/db.php	12 Jan 2005 20:17:16 -0000	1.9
+++ include/db.php	13 Jan 2005 03:31:07 -0000
@@ -13,6 +13,21 @@
     return $hResult;
 }
 
+function query_userdb($sQuery,$sComment="")
+{
+    global $huserdbLink;
+
+    if(!$huserdbLink)
+    {
+        $huserdbLink = mysql_connect(USERS_DBHOST, USERS_DBUSER, USERS_DBPASS);
+        mysql_select_db(USERS_DB);
+    }
+    $hResult = mysql_query($sQuery, $huserdbLink);
+    if(!$hResult) query_error($sQuery, $sComment);
+    return $hResult;
+}
+
+
 
 function query_bugzilladb($sQuery,$sComment="")
 {
Index: preferences.php
===================================================================
RCS file: /home/wine/appdb/preferences.php,v
retrieving revision 1.13
diff -u -r1.13 preferences.php
--- preferences.php	12 Jan 2005 16:22:55 -0000	1.13
+++ preferences.php	13 Jan 2005 03:31:07 -0000
@@ -17,7 +17,7 @@
 
 function build_prefs_list()
 {
-    $result = query_appdb("SELECT * FROM prefs_list ORDER BY id");
+    $result = query_userdb("SELECT * FROM prefs_list ORDER BY id");
     while($r = mysql_fetch_object($result))
         {
             //skip admin options

[AppDB] Now User Preferences is Br0ck. (fix sort of?)

[Paul van Schayck]

Hey Tony,

On Wed, 12 Jan 2005 20:39:19 -0700, tony_lambregts(a)telusplanet.net
<tony_lambregts(a)telusplanet.net> wrote:
> > Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to
> > allocate 68254 bytes) in /var/www/html/appdb/include/db.php on line 35
> >
> > Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to
> > allocate 136 bytes) in Unknown on line 0

Which PHP version are you running (and which one is the live server).
I don't see it happening (4.3.9) and neither does Jonathan (5.x).
> This patch fixes it on my system. the wierd thing is that on my system I have.
>
> define("APPS_DB","apidb");
> and
> define("USERS_DB","apidb");
>
> So why would it make any difference?

This is the most weird thing I've ever seen. Are we overloading the
connection or something. And consider this aswell:

" If a second call is made to mysql_connect()  with the same
arguments, no new link will be established, but instead, the link
identifier of the already opened link will be returned."

The only consistent I've seen yet is that it's always this line:
$sStatusMessage .= "Query: ".$sQuery;

Really weird,
Paul