failure to recognize "early 2009" Mac Mini nVidia 9400 OpenGL version string

Hi,

as of wine-1.1.21, wine does not recognize the "early 2009" Mac Mini
OpenGL version string from nVidia:
err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44"

The string probably originates from XQuartz' X11.2.3.3.2. The wine
source code expects a space after NVIDIA. On Linux, the numbers are
much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google.

Before I submit a patch to have wine recognize either space or "-" as
separator, I'd like to query the list whether it actually makes sense
to return major = 1, minor = 5, i.e. Apple numbers to a MS-Windows program?

Or should I not care about the useage and just parse the string (i.e. submit patch)?

Thanks,
	Jörg Höhle

failure to recognize "early 2009" Mac Mini nVidia 9400 OpenGL version string

[Roderick Colenbrander]

On Mon, May 25, 2009 at 12:18 PM,  <Joerg-Cyril.Hoehle(a)t-systems.com> wrote:
> Hi,
>
> as of wine-1.1.21, wine does not recognize the "early 2009" Mac Mini
> OpenGL version string from nVidia:
> err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44"
>
> The string probably originates from XQuartz' X11.2.3.3.2. The wine
> source code expects a space after NVIDIA. On Linux, the numbers are
> much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google.
>
> Before I submit a patch to have wine recognize either space or "-" as
> separator, I'd like to query the list whether it actually makes sense
> to return major = 1, minor = 5, i.e. Apple numbers to a MS-Windows program?
>
> Or should I not care about the useage and just parse the string (i.e. submit patch)?
>
> Thanks,
>        Jörg Höhle

The version string parsing isn't that important. The version number we
return isn't based on this anymore. We use a lookup table in case of
nvidia.

Roderick

failure to recognize "early 2009" Mac Mini nVidia 9400 OpenGL version string

[Stefan Dösinger]

Am Montag, 25. Mai 2009 12:18:55 schrieb Joerg-Cyril.Hoehle(a)t-systems.com:
> Before I submit a patch to have wine recognize either space or "-" as
> separator, I'd like to query the list whether it actually makes sense
> to return major = 1, minor = 5, i.e. Apple numbers to a MS-Windows program?
> No, it doesn't, and I don't think we're doing anything useful right now with 
> the parsed driver version. We only use the parsed OpenGL version, which is 
> the same format everywhere.

Once upon a time we passed that version to the windows game, but as you said, 
this doesn't make sense. So these days we have a (PCI_VEN/PCI_DEV)->driver 
version mapping where we hardcode the latest known Windows driver 
version(that table needs an update).

I think the other idea to keep the driver version passing was to be able to 
work around known bugs, but currently there aren't and driver version 
dependent workarounds, and I don't know if there ever will be(we dislike 
hacks to workaround bugs).

So feel free to kill the whole driver version parsing.