Re: [PATCH] d3d11: Add stub implementation for deferred context.

[Henri Verbeet]

Other than some minor comments below, the patch itself is mostly ok.
Unfortunately, the issue is that it's not clear that this is the right
direction for implementing deferred contexts. In particular, it seems
likely that we'll handle the difference between immediate and deferred
contexts inside wined3d, and only have a single implementation in
d3d11. Of course that's one of those things where you won't know how
well it works until you try it.

On 2 October 2016 at 08:39, Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote:
> -»······view.c
> +»······view.c \
> +»······deferred.c
> It's pretty minor, but please keep these ordered.
> +    if (context)
> +    {
> Is it valid for context to be NULL here? The test doesn't cover it.
> +        *context = (ID3D11DeviceContext *)&object->ID3D11DeviceContext_iface;
> That cast seems unnecessary.