Steam regression in CVS

[James Liggett]

Hi,
Yesterday I found a regression in Steam in current CVS. It fails to
start, giving the error message: "ERROR: Failed to get local IP address
of SocketToServer." Steam dies a few seconds after this. I tracked down
the cause to a recent Winsock patch:
http://www.winehq.com/pipermail/wine-cvs/2005-November/019293.html

Can someone confirm this/take a look at it? Thanks.

James

[Vijay Kiran Kamuju]

Patch has been submitted
http://www.winehq.org/pipermail/wine-patches/2005-November/022225.html
Thanks,
vijay

On 11/19/05, James Liggett <jrliggett(a)cox.net> wrote:
> Hi,
> Yesterday I found a regression in Steam in current CVS. It fails to
> start, giving the error message: "ERROR: Failed to get local IP address
> of SocketToServer." Steam dies a few seconds after this. I tracked down
> the cause to a recent Winsock patch:
> http://www.winehq.com/pipermail/wine-cvs/2005-November/019293.html
>
> Can someone confirm this/take a look at it? Thanks.
>
> James

[Evil]

I can confirm this.  I see the same error since the patch.

-Jesse


James Liggett wrote:
> Hi,
> Yesterday I found a regression in Steam in current CVS. It fails to
> start, giving the error message: "ERROR: Failed to get local IP address
> of SocketToServer." Steam dies a few seconds after this. I tracked down
> the cause to a recent Winsock patch:
> http://www.winehq.com/pipermail/wine-cvs/2005-November/019293.html
>
> Can someone confirm this/take a look at it? Thanks.
>
> James

[Marcus Meissner]

On Sat, Nov 19, 2005 at 06:39:23AM -0600, Evil wrote:
> I can confirm this.  I see the same error since the patch.

I have sent in a fix already but it was not applied yet.

Here it is for your viewing pleasure....

Ciao, Marcus

Index: dlls/winsock/socket.c
===================================================================
RCS file: /home/wine/wine/dlls/winsock/socket.c,v
retrieving revision 1.195
diff -u -r1.195 socket.c
--- dlls/winsock/socket.c	17 Nov 2005 12:58:35 -0000	1.195
+++ dlls/winsock/socket.c	18 Nov 2005 20:25:41 -0000
@@ -1076,7 +1076,7 @@
         win->sin_family = WS_AF_INET;
         win->sin_port   = uin->sin_port;
         memcpy(&win->sin_addr,&uin->sin_addr,4); /* 4 bytes = 32 address bits */
-        *wsaddrlen = sizeof(struct WS_sockaddr_in6);
+        *wsaddrlen = sizeof(struct WS_sockaddr_in);
         return 0;
     }
     default:

[James Liggett]

I applied last night to my tree. It fixes the problem. Thanks.

James

On Sat, 2005-11-19 at 15:52 +0100, Marcus Meissner wrote:
> On Sat, Nov 19, 2005 at 06:39:23AM -0600, Evil wrote:
> > I can confirm this.  I see the same error since the patch.
>
> I have sent in a fix already but it was not applied yet.
>
> Here it is for your viewing pleasure....
>
> Ciao, Marcus
>
> Index: dlls/winsock/socket.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/winsock/socket.c,v
> retrieving revision 1.195
> diff -u -r1.195 socket.c
> --- dlls/winsock/socket.c	17 Nov 2005 12:58:35 -0000	1.195
> +++ dlls/winsock/socket.c	18 Nov 2005 20:25:41 -0000
> @@ -1076,7 +1076,7 @@
>          win->sin_family = WS_AF_INET;
>          win->sin_port   = uin->sin_port;
>          memcpy(&win->sin_addr,&uin->sin_addr,4); /* 4 bytes = 32 address bits */
> -        *wsaddrlen = sizeof(struct WS_sockaddr_in6);
> +        *wsaddrlen = sizeof(struct WS_sockaddr_in);
>          return 0;
>      }
>      default: