Re: wined3d: don't set cube and volume POW2 caps if np2 textures are supported
Stefan Dösinger <stefan(a)codeweavers.com> writes:
From aa344834084ef89c654011804e6e2faccafe1e5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20D=C3=B6singer?= <stefan(a)codeweavers.com> Date: Sun, 21 Nov 2010 18:08:41 +0100 Subject: [PATCH] wined3d: don't set cube and volume POW2 caps if np2 textures are supported
It doesn't work here: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:236: Test failed: Returned mipmaps 9, expected 10 texture.c:242: Test failed: Returned mipmaps 6, expected 7 texture.c:381: Test failed: Returned mipmaps 9, expected 10 make: *** [texture.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org
On 23 November 2010 16:23, Alexandre Julliard <julliard(a)winehq.org> wrote:
It doesn't work here:
../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:236: Test failed: Returned mipmaps 9, expected 10 texture.c:242: Test failed: Returned mipmaps 6, expected 7 texture.c:381: Test failed: Returned mipmaps 9, expected 10 make: *** [texture.ok] Error 3
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare.
Am Dienstag 23 November 2010, 16:52:09 schrieb Henri Verbeet:
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare. If the test was broken I'd expect it to fail on Windows, but it doesn't:
http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... wxp-32b-ie6/d3dx9_36:surface.html According to http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... wxp-32b-ie6/d3d9:visual.html from the same machine this card has a Geforce 8600 and is properly set up. I'd be pretty surprised if this card doesn't support NP2 cubemaps. I don't have such a card, but my geforce9600 supports NP2 cubemaps(which is how I became aware of the caps difference)
2010/11/23 Stefan Dösinger <stefan(a)codeweavers.com>:
Am Dienstag 23 November 2010, 16:52:09 schrieb Henri Verbeet:
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare. If the test was broken I'd expect it to fail on Windows, but it doesn't:
http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... wxp-32b-ie6/d3dx9_36:surface.html
According to http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... wxp-32b-ie6/d3d9:visual.html
from the same machine this card has a Geforce 8600 and is properly set up. I'd be pretty surprised if this card doesn't support NP2 cubemaps. I don't have such a card, but my geforce9600 supports NP2 cubemaps(which is how I became aware of the caps difference)
The test failing for AJ on his machine actually fails on that same Windows machine you looked at: http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... So, yes, it seems like the test is broken. I added it recently, didn't notice the failures before. I'll take a look.
On 23 November 2010 17:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am Dienstag 23 November 2010, 16:52:09 schrieb Henri Verbeet:
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare. If the test was broken I'd expect it to fail on Windows, but it doesn't:
http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_Wyld... wxp-32b-ie6/d3dx9_36:surface.html
That's because that's a different test.
Am Dienstag 23 November 2010, 17:22:50 schrieb Henri Verbeet:
On 23 November 2010 17:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am Dienstag 23 November 2010, 16:52:09 schrieb Henri Verbeet:
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare.
If the test was broken I'd expect it to fail on Windows, but it doesn't:
http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_W yldBOT1- wxp-32b-ie6/d3dx9_36:surface.html
That's because that's a different test. You are right, I must have jumped a line up when I navigated through the test data. I should have noticed that when I pasted the link.
On 23 November 2010 21:23, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am Dienstag 23 November 2010, 17:22:50 schrieb Henri Verbeet:
On 23 November 2010 17:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am Dienstag 23 November 2010, 16:52:09 schrieb Henri Verbeet:
Looks like a flaw in the d3dx9_36 test, it isn't taking the POW2 cap into account. I would have expected that to fail the other way around though, cards that can't do npot textures should be pretty rare.
If the test was broken I'd expect it to fail on Windows, but it doesn't:
http://test.winehq.org/data/892502479c3acf64257e19ec4aac113024642f4d/xp_W yldBOT1- wxp-32b-ie6/d3dx9_36:surface.html
That's because that's a different test. You are right, I must have jumped a line up when I navigated through the test data. I should have noticed that when I pasted the link.
Did this patch go anywhere? AFAIK Matteo already fixed the tests.
participants (4)
-
Alexandre Julliard -
Henri Verbeet -
Matteo Bruni -
Stefan Dösinger