Re: [PATCH] winedump: Improve typelib header dumping

[Jacek Caban]

Hi Nikolay,

On 03/14/14 14:48, Nikolay Sivov wrote:
> +            if (flags & 1)
> +                printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0);
> +            flags >>= 1;

i should be increased on each iteration, not only when the flag is found.

Cheers,
Jacek

[PATCH] winedump: Improve typelib header dumping

[Jacek Caban]

On 03/14/14 15:04, Jacek Caban wrote:
> Hi Nikolay,
>
> On 03/14/14 14:48, Nikolay Sivov wrote:
> > +            if (flags & 1)
> > +                printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0);
> > +            flags >>= 1;
> > i should be increased on each iteration, not only when the flag is found.

Also you should print '\n' instead of nullbyte if no more flags are found.

Cheers,
Jacek