Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest. (RESEND)

[Nikolay Sivov]

On Sun, May 22, 2011 at 6:07 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote:
> Any problems with this patch I submitted back in February?

I believe I mentioned it, or I should have. Message handler is
incomplete, cause it should return text as well, that's why it has A/W
versions. This needs tests and proper implementation, not just
reducing parameters list for no reason. (and if tests show no use of
text for these messages it's a reason of course)
> Gerald
>
> ---
>  dlls/comctl32/tooltips.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c
> index a2e58e0..445845c 100644
> --- a/dlls/comctl32/tooltips.c
> +++ b/dlls/comctl32/tooltips.c
> @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW)
>
>  static LRESULT
> -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit,
> -                   BOOL isW)
> +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit)
>  {
>     TTTOOL_INFO *toolPtr;
>     INT nTool;
> @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
>
>        case TTM_HITTESTA:
>        case TTM_HITTESTW:
> -           return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam,
> -                                      uMsg == TTM_HITTESTW);
> +           return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam);
> +
>        case TTM_NEWTOOLRECTA:
>        case TTM_NEWTOOLRECTW:
>            return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam);
> --
> 1.7.4.1