Multiple test failures in Gitlab's CI

[Barath Rk]

I recently created this MR in Gitlab:
https://gitlab.winehq.org/wine/wine/-/merge_requests/11079 which had 52
test failures in the CI.

However, some other merged requests appear to similarly have many failures.
My question is, should I attribute these test failures to a flaky CI and
just wait for review, or try to resolve it on my end?

Thanks in advance.

[Zhiyi Zhang]

It looks like those CI test failures are related to your changes. So you should fix them.

On 6/8/26 09:53, Barath Rk via Wine-Devel wrote:
> I recently created this MR in Gitlab: https://gitlab.winehq.org/wine/wine/-/merge_requests/11079 which had 52 test failures in the CI.
>
> However, some other merged requests appear to similarly have many failures. My question is, should I attribute these test failures to a flaky CI and just wait for review, or try to resolve it on my end?
>
> Thanks in advance.

[Barath Rk]

Thanks, I fixed the cmd test failures locally, added a new test and pushed
the changes.


On Mon, 8 Jun, 2026, 8:11 am Zhiyi Zhang, <[e-mail]> wrote:
> It looks like those CI test failures are related to your changes. So you
> should fix them.
>
> On 6/8/26 09:53, Barath Rk via Wine-Devel wrote:
> > I recently created this MR in Gitlab:
> > https://gitlab.winehq.org/wine/wine/-/merge_requests/11079 which had 52
> > test failures in the CI.
> >
> > However, some other merged requests appear to similarly have many
> > failures. My question is, should I attribute these test failures to a flaky
> > CI and just wait for review, or try to resolve it on my end?
> >
> > Thanks in advance.

[Barath Rk]

However, I still have 4 failures in webservices/tests/writer.c where there
are a few one-off failures(Opened a new MR:
https://gitlab.winehq.org/wine/wine/-/merge_requests/11094). From what I
can tell, there is no call that goes to type. so it seems like it isn't a
failure from my side. Am I missing something?

On Tue, Jun 9, 2026 at 12:48 PM Barath Rk <[e-mail]> wrote:
> Thanks, I fixed the cmd test failures locally, added a new test and pushed
> the changes.
>
> On Mon, 8 Jun, 2026, 8:11 am Zhiyi Zhang, <[e-mail]> wrote:
> > It looks like those CI test failures are related to your changes. So you
> > should fix them.
> >
> > On 6/8/26 09:53, Barath Rk via Wine-Devel wrote:
> > > I recently created this MR in Gitlab:
> > > https://gitlab.winehq.org/wine/wine/-/merge_requests/11079 which had 52
> > > test failures in the CI.
> > >
> > > However, some other merged requests appear to similarly have many
> > > failures. My question is, should I attribute these test failures to a flaky
> > > CI and just wait for review, or try to resolve it on my end?
> > >
> > > Thanks in advance.