[PATCH 1/2] ole32: Lock spies list when iterating it.
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ole32/compobj.c | 65 +++++++++++++++++++++++++++--------- dlls/ole32/compobj_private.h | 1 + 2 files changed, 50 insertions(+), 16 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=56857 Your paranoid android. === debian10 (32 bit report) === ole32: dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:713: Test failed: DoDragDrop_ret: unexpected param 00040100 expected beefbeef dragdrop.c:714: Test failed: DoDragDrop_effect_out: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave Unhandled exception: divide by zero in 32-bit code (0x7e8ef421). Report errors: ole32:ole2 crashed (c0000094) === debian10 (32 bit Chinese:China report) === ole32: dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:713: Test failed: DoDragDrop_ret: unexpected param 00040100 expected beefbeef dragdrop.c:714: Test failed: DoDragDrop_effect_out: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave Unhandled exception: divide by zero in 32-bit code (0x7eb69421). Report errors: ole32:ole2 crashed (c0000094) === debian10 (32 bit WoW report) === ole32: dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:713: Test failed: DoDragDrop_ret: unexpected param 00040100 expected beefbeef dragdrop.c:714: Test failed: DoDragDrop_effect_out: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave Unhandled exception: divide by zero in 32-bit code (0x7e8ef421). Report errors: ole32:ole2 crashed (c0000094) === debian10 (64 bit WoW report) === ole32: dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:713: Test failed: DoDragDrop_ret: unexpected param 00040100 expected beefbeef dragdrop.c:714: Test failed: DoDragDrop_effect_out: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragEnter dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DS_GiveFeedback dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_Drop dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragEnter dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:362: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:369: Test failed: unexpected call DS_GiveFeedback instead of DT_DragOver dragdrop.c:369: Test failed: DS_GiveFeedback: unexpected param 00000000 expected 00000001 dragdrop.c:713: Test failed: unexpected call DoDragDrop_ret instead of DT_DragLeave Unhandled exception: divide by zero in 32-bit code (0x7e8ef421). Report errors: ole32:ole2 crashed (c0000094)
participants (2)
-
Jacek Caban -
Marvin