Re: wineandroid: Add suffix to lib directory and wine binary on 64-bit

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> This fixes at least arm64-v8a builds, where you have lib64/libwine.so and bin/wine64
>
> Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> ---
>
> This and "winebuild: Improved position independent code generation" enable Wine on ARM64 Android phones (e.g. most Android devices).
> The check for 64 in the CPU_ABI can be discussed, but I think it's reliable and fast.
>
> dlls/wineandroid.drv/WineActivity.java | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

We already prefix with the ABI, so I think plain "lib" is better.

-- 
Alexandre Julliard
julliard(a)winehq.org

wineandroid: Add suffix to lib directory and wine binary on 64-bit

[André Hentschel]

Am 08.08.2017 um 13:16 schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > This fixes at least arm64-v8a builds, where you have lib64/libwine.so and bin/wine64
> >
> > Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> > ---
> >
> > This and "winebuild: Improved position independent code generation" enable Wine on ARM64 Android phones (e.g. most Android devices).
> > The check for 64 in the CPU_ABI can be discussed, but I think it's reliable and fast.
> >
> > dlls/wineandroid.drv/WineActivity.java | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
>
> We already prefix with the ABI, so I think plain "lib" is better.

The thing is that everything is installed to lib64, should I have a look in changing this?
Also it sounds like doing suffix for the wine binary is ok?

wineandroid: Add suffix to lib directory and wine binary on 64-bit

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> Am 08.08.2017 um 13:16 schrieb Alexandre Julliard:
> > André Hentschel <nerv(a)dawncrow.de> writes:
> > > This fixes at least arm64-v8a builds, where you have lib64/libwine.so and bin/wine64
> > >
> > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> > > ---
> > >
> > > This and "winebuild: Improved position independent code generation" enable Wine on ARM64 Android phones (e.g. most Android devices).
> > > The check for 64 in the CPU_ABI can be discussed, but I think it's reliable and fast.
> > >
> > > dlls/wineandroid.drv/WineActivity.java | 8 ++++++--
> > >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > We already prefix with the ABI, so I think plain "lib" is better.
>
> The thing is that everything is installed to lib64, should I have a look in changing this?

configure --libdir is the easiest, but we could probably change the
default. It's not clear that lib64 makes much sense for Linux either
these days.
> Also it sounds like doing suffix for the wine binary is ok?

It shouldn't be needed either, but wow64 support is going to take a bit
more work.

-- 
Alexandre Julliard
julliard(a)winehq.org