Submitting patches to staging
Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging? My repository fully complies with Wine's cleanroom guidelines, and more importantly, I *do not, and under no circumstances,* use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation. Best Regards.
On Tuesday, 4 November 2025 00:58:19 CST light gray wrote:
Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging?
My repository fully complies with Wine's cleanroom guidelines, and more importantly, I *do not, and under no circumstances,* use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation.
That seems to be a complete understanding of our legal and authorship requirements. We do want to make sure the patches are going in the right direction. Also, we encourage people to at least try to get their patches upstream if they're able. I'd offer comment on the patches in question, but it looks like you're using merges so I'm not sure I'll be able to find all of them. It does look like you're working on the "gameinput" DLL, which I think Rémi Bernon is also working on, so it would be prudent for us to coordinate that first.
On Nov 4, 2025, at 10:28 AM, light gray <tpapata1386(a)gmail.com> wrote: Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging?
My repository fully complies with Wine's cleanroom guidelines, and more importantly, I do not, and under no circumstances, use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation.
Best Regards.
After careful consideration, unfortunately, both because of my current conditions and the crucial nature for me to stay anonymous, I won’t be submitting my patches upstream. However, my code will remain/become public domain and is still compliant with Wine’s cleanroom guidelines. Thanks a lot for guiding me through this, I wish you the best.
"the crucial nature for me to stay anonymous" This can be waived if you are willing to pass up your attribution - it will be re-authored by another non-anonymous user if you request a waiver to the rule. I have some misgivings about how this is handled (attribution is important but now isn't the time to discuss that), however it is a possibility. I have gone this route myself to get some fixes merged in the past, and is documented on the wiki for contribution guidelines. On Tue, Nov 4, 2025 at 3:31 PM light gray <tpapata1386(a)gmail.com> wrote:
On Nov 4, 2025, at 10:28 AM, light gray <tpapata1386(a)gmail.com> wrote:
Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging?
My repository fully complies with Wine's cleanroom guidelines, and more importantly, I *do not, and under no circumstances,* use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation.
Best Regards.
After careful consideration, unfortunately, both because of my current conditions and the crucial nature for me to stay anonymous, I won’t be submitting my patches upstream. However, my code will remain/become public domain and is still compliant with Wine’s cleanroom guidelines.
Thanks a lot for guiding me through this, I wish you the best.
I think the common practice in such cases is that the patch is pulled / sent by someone with the real name and their name in From:, while patch comment has "Patch by ..." with original author email / pseudonym (or 'based on patch by' if the patch was modified beyond some formatting changes. But I think it is not clear what is the future of GDK and specifically game input in upstream Wine. WRT gameinput, AFAIU it doesn't have a stable API (at least yet) and the games are supposed to ship it (while some indeed don't). WRT xgameruntime.dll, is there any valid source of info for those internal interfaces details? Separately, when I was once looking at xgameruntime, the major problem to get any use of its implementation seemed to be linking the implementation to actual application data game requests through that (i. e., it must query MS servers for that). I wonder were there any thoughts on that part? On 11/5/25 15:51, Ty wrote:
"the crucial nature for me to stay anonymous" This can be waived if you are willing to pass up your attribution - it will be re-authored by another non-anonymous user if you request a waiver to the rule. I have some misgivings about how this is handled (attribution is important but now isn't the time to discuss that), however it is a possibility. I have gone this route myself to get some fixes merged in the past, and is documented on the wiki for contribution guidelines.
On Tue, Nov 4, 2025 at 3:31 PM light gray <tpapata1386(a)gmail.com> wrote:
On Nov 4, 2025, at 10:28 AM, light gray <tpapata1386(a)gmail.com> wrote:
Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging?
My repository fully complies with Wine's cleanroom guidelines, and more importantly, I *do not, and under no circumstances,* use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation.
Best Regards.
After careful consideration, unfortunately, both because of my current conditions and the crucial nature for me to stay anonymous, I won’t be submitting my patches upstream. However, my code will remain/become public domain and is still compliant with Wine’s cleanroom guidelines.
Thanks a lot for guiding me through this, I wish you the best.
There is no valid information anywhere about how COM interfaces are implemented internally for xgameruntime.dll so I had to do a lot of guesswork and I have documented how I went about implementing them within `QueryApiImpl`. Unfortunately as a result, this leads to functions in which I simply have no clue how they behave, what their signature is or what they return. (example: https://github.com/Weather-OS/WineGDK/blob/master/dlls/xgameruntime/GDKCompo... ) There's also the matter of NDA'd interfaces such as the Graphics API or the Audio API. There's simply no way for us to implement those but thankfully those tend to be exclusive to Xbox consoles. For Microsoft services, I don't think any approach we use can be upstreamable because it goes against the whole point of the Wine project being MS free. However I would still implement them within WineGDK and ask for user consent if they want Wine to interact with Microsoft services. On Thu, 6 Nov 2025 at 01:33, Paul Gofman <pgofman(a)codeweavers.com> wrote:
I think the common practice in such cases is that the patch is pulled / sent by someone with the real name and their name in From:, while patch comment has "Patch by ..." with original author email / pseudonym (or 'based on patch by' if the patch was modified beyond some formatting changes.
But I think it is not clear what is the future of GDK and specifically game input in upstream Wine. WRT gameinput, AFAIU it doesn't have a stable API (at least yet) and the games are supposed to ship it (while some indeed don't).
WRT xgameruntime.dll, is there any valid source of info for those internal interfaces details? Separately, when I was once looking at xgameruntime, the major problem to get any use of its implementation seemed to be linking the implementation to actual application data game requests through that (i. e., it must query MS servers for that). I wonder were there any thoughts on that part?
On 11/5/25 15:51, Ty wrote:
"the crucial nature for me to stay anonymous" This can be waived if you are willing to pass up your attribution - it will be re-authored by another non-anonymous user if you request a waiver to the rule. I have some misgivings about how this is handled (attribution is important but now isn't the time to discuss that), however it is a possibility. I have gone this route myself to get some fixes merged in the past, and is documented on the wiki for contribution guidelines.
On Tue, Nov 4, 2025 at 3:31 PM light gray <tpapata1386(a)gmail.com> wrote:
On Nov 4, 2025, at 10:28 AM, light gray <tpapata1386(a)gmail.com> wrote:
Hi! On the condition that I de-anonymize myself, would it be possible for me to submit my patches over at https://github.com/Weather-OS/WineGDK to wine staging?
My repository fully complies with Wine's cleanroom guidelines, and more importantly, I *do not, and under no circumstances,* use AI generated code to implement API functionality. I solely rely on tests written and compiled within a Windows environment and Microsoft's own documentation.
Best Regards.
After careful consideration, unfortunately, both because of my current conditions and the crucial nature for me to stay anonymous, I won’t be submitting my patches upstream. However, my code will remain/become public domain and is still compliant with Wine’s cleanroom guidelines.
Thanks a lot for guiding me through this, I wish you the best.
It seems odd that no one has taken the bother to actually submit this under their name, but: I really want this to be upstreamed. Like, a lot. My job requires me to have a functioning (even if offline) copy of MCBE working on my machine, and so far this has been the only solution that makes it possible. However, updating Wine and WineGDK is an absolute pain and bother, so I would really like for this to be upstreamed. I assume someone else probably is already willing to give their real name to submit this, but in the remote chance no one actually stepped up and gave the name, I'm absolutely willing to use my name to get this upstreamed. I don't care to take recognition, the work LightGray has done is godsent and I would never in a hundred years get to that level. I wanna do this purely to get this upstreamed and for the convenience of my workplace. And also, I feel like the Deck is almost *made* for MCBE. We're sitting on gold here, I really want this to be upstreamed. I'm willing to be actively (or passively) involved in future patches as well if it means getting MCBE to work on my machine with sudo dnf install wine... Genuinely would be a game changer. Thanks
participants (5)
-
Elizabeth Figura -
light gray -
oosakadayoh＠gmail.com -
Paul Gofman -
Ty