Re: [DSHOW] Beginning of winestreambase lib (take 2)

[Christian Costa]

Christian Costa wrote:
> Hi,
>
> This time, with winestrmbase renamed to winestreambase as suggested by 
> Dimi.
>
> Changelog:
> Add winestreambase library and make quartz use it.
>
> Christian Costa   titan.costa(a)wanadoo.fr

This patch has not be applied yet. Is there anything wrong with it?
I was also considering turning it into a dll rather than a static lib. 
Do you think it's a good idea?

Christian

[DSHOW] Beginning of winestreambase lib (take 2)

[Alexandre Julliard]

Christian Costa <titan.costa(a)wanadoo.fr> writes:
> This patch has not be applied yet. Is there anything wrong with it?
> I was also considering turning it into a dll rather than a static
> lib. Do you think it's a good idea?

No, I don't think it should be a dll. I think it should be named
strmbase and should export the exact same things as Windows, modulo
C/C++ differences of course. This means the data structures and global
functions should be the same, the C interfaces should use the same
name as the equivalent C++ classes, etc. and it shouldn't export extra
things like the qzdebugstr functions.

-- 
Alexandre Julliard
julliard(a)winehq.org

[DSHOW] Beginning of winestreambase lib (take 2)

[Christian Costa]

Alexandre Julliard wrote:
> Christian Costa <titan.costa(a)wanadoo.fr> writes:
> > This patch has not be applied yet. Is there anything wrong with it?
> > I was also considering turning it into a dll rather than a static
> > lib. Do you think it's a good idea?
>
> No, I don't think it should be a dll. I think it should be named
> strmbase and should export the exact same things as Windows, modulo
> C/C++ differences of course. This means the data structures and global
> functions should be the same, the C interfaces should use the same
> name as the equivalent C++ classes, etc. and it shouldn't export extra
> things like the qzdebugstr functions.

Ok! I will see what I can do. Thanks.