RE: Spore patch to fix UI and Part descriptions

[Stefan Dösinger]

These changes may be correct, but they need a test. Take a look at dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes are likely to be correct, but they have to be tested

Spore patch to fix UI and Part descriptions

[H. Verbeet]

2008/8/21 Stefan Dösinger <stefan(a)codeweavers.com>:
> These changes may be correct, but they need a test. Take a look at dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes are likely to be correct, but they have to be tested

Not in its current form, there's a C++ comment and trailing spaces in
there, and the change in SetScissorRect() probably should test if the
rectangle is empty. Also, if it tests for empty rectangles, it should
probably also test for rectangles that are (partially) outside the
screen, etc.

Spore patch to fix UI and Part descriptions

[Andrew Fenn]

On Thu, Aug 21, 2008 at 9:41 PM, Stefan Dösinger <stefan(a)codeweavers.com>wrote:
> These changes may be correct, but they need a test. Take a look at
> dlls/d3d9/tests/device.c to see how the other tests look. I guess the
> changes are likely to be correct, but they have to be tested

I'll add a test case and get back to you later then, thanks for the help.

On Thu, Aug 21, 2008 at 9:51 PM, H. Verbeet <hverbeet(a)gmail.com> wrote:
> Not in its current form, there's a C++ comment and trailing spaces in
> there, and the change in SetScissorRect() probably should test if the
> rectangle is empty. Also, if it tests for empty rectangles, it should
> probably also test for rectangles that are (partially) outside the
> screen, etc.

I'll change the code around and add the checking you mentioned.

Thanks for the info.

Regards,
Andrew

Spore patch to fix UI and Part descriptions

[gorry]

One of the best kept secrets of these major wine festivals is how much time
and energy they save you. Just think of having to drive from Deep Creek Lake
in far-western Maryland to the Eastern Shore and Southern Maryland to visit
every winery. The festivals bring Maryland’s finest wines to your backyard,
saving you a couple tanks of rather expensive gas. And since many of the
wineries offer special festival pricing, you can use that saved cash to take
home a few bottles of your new favorite wines. 

http://www.wineclubdirectory.net  Wine Club  


-- 
View this message in context: http://www.nabble.com/RE%3A-Spore-patch-to-fix-UI-and-Part-descriptions-tp19...
Sent from the Wine - Devel mailing list archive at Nabble.com.