Re: [PATCH] winex11: Avoid inefficiency and overflow in remove_startup_notification.

[Alex Henrie]

Could I get some feedback on this patch? I'd rather not have it drop
off the list a second time, especially since Vincent already signed
off on it: https://www.winehq.org/pipermail/wine-patches/2015-November/144119.html

-Alex

[PATCH] winex11: Avoid inefficiency and overflow in remove_startup_notification.

[Alexandre Julliard]

Alex Henrie <alexhenrie24(a)gmail.com> writes:
> Could I get some feedback on this patch? I'd rather not have it drop
> off the list a second time, especially since Vincent already signed
> off on it: https://www.winehq.org/pipermail/wine-patches/2015-November/144119.html

It's not fixing any inefficiency (on the contrary it's now allocating
unneeded stack space) and it's not making things better. Please either
concentrate on fixing only the reported issue, or else make it truly
better; changing things for the sake of changing is not a good idea.

-- 
Alexandre Julliard
julliard(a)winehq.org