Re: makefiles: Add some msvcrt imports needed under Cygwin
On Sat, Feb 20, 2010 at 11:20 AM, <cerebro.alexiel(a)gmail.com> wrote:
diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in index dce8259..1a36216 100644 --- a/programs/xcopy/Makefile.in +++ b/programs/xcopy/Makefile.in @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = xcopy.exe APPMODE = -mconsole -municode -mno-cygwin -IMPORTS = shell32 user32 kernel32 +IMPORTS = shell32 user32 kernel32 msvcrt EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt MODCFLAGS = @BUILTINFLAG@
This patch won't apply cleanly on top of the first, you've still got -mno-cygwin in there. -- -Austin
Le 21/02/2010 18:48, Austin English a écrit :
On Sat, Feb 20, 2010 at 11:20 AM,<cerebro.alexiel(a)gmail.com> wrote:
diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in index dce8259..1a36216 100644 --- a/programs/xcopy/Makefile.in +++ b/programs/xcopy/Makefile.in @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = xcopy.exe APPMODE = -mconsole -municode -mno-cygwin -IMPORTS = shell32 user32 kernel32 +IMPORTS = shell32 user32 kernel32 msvcrt EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt MODCFLAGS = @BUILTINFLAG@
This patch won't apply cleanly on top of the first, you've still got -mno-cygwin in there.
It's the first time I post patches so I didn't know. I will try to resend a proper version within the week or at least the next week end. Thanks again
On Sun, Feb 21, 2010 at 3:33 PM, Alex <cerebro.alexiel(a)gmail.com> wrote:
-IMPORTS = shell32 user32 kernel32 +IMPORTS = shell32 user32 kernel32 msvcrt
Unless something has changed I don't think we want to do this anyway. What we need is something like the EXTRALIBS rule that adds msvcrt if its on cygwin. Take a look at what we do in wininet so that we link to winsock on mingw but use standard sockets the rest of the time. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
On Mon, Feb 22, 2010 at 1:25 AM, Steven Edwards <winehacker(a)gmail.com>wrote:
Unless something has changed I don't think we want to do this anyway. What we need is something like the EXTRALIBS rule that adds msvcrt if its on cygwin. Take a look at what we do in wininet so that we link to winsock on mingw but use standard sockets the rest of the time.
Thanks
Ok, thanks : I'm still learning. I'll try to send a better patch next time (probably next week end).
participants (3)
-
Alex -
Austin English -
Steven Edwards