Re: dlls/ws2_32/tests/sock.c: Wait on thread handles before closing sockets
July 16, 2008
1:16 p.m.
Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes:
In the socket tests, avoid a race by waiting for the read threads to finish before closing the sockets (found during TransmitFile testing).
CloseHandle doesn't wait for the thread to finish, so this has no effect. In any case there doesn't seem to be any need to wait in those tests. -- Alexandre Julliard julliard(a)winehq.org
July 2008
4:01 p.m.
New subject: dlls/ws2_32/tests/sock.c: Wait on thread handles before closing sockets
CloseHandle doesn't wait for the thread to finish, so this has no effect. In any case there doesn't seem to be any need to wait in those tests.
My bad. There was something hokey with the tests, moving the CloseHandle made them pass consistently. After changing the implementation I can't repeat it. I'll resend when I get some time this weekend. Cheers Jon
6461
Age (days ago)
6462
Last active (days ago)
1 comments
2 participants
participants (2)
-
Alexandre Julliard -
Jon Griffiths