Re: msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)

[James McKenzie]

Stefano Guidoni wrote:
> This patch implements ACM_FORMATENUMF_SUGGEST and fixes bug 16394.
> > From MSDN: "The WAVEFORMATEX structure pointed to by the pwfx
> > member
> > of 
> > the ACMFORMATDETAILS structure is valid. The enumerator will
> > enumerate 
> > all suggested destination formats for the given pwfx
> > format.".
> > Since 
> > the WAVEFORMATEX structure is valid, there is no need
> > to cycle through 
> > all the standard formats (moreover the WAVEFORMATEX
> > format could be not 
> > a standard one).
>
> S. Guidoni
> ------------------------------------------------------------------------

Can you please use standard compression programs with standard extensions.

Your file extension, .bin will not work here.

James McKenzie

msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)

[Henri Verbeet]

2009/3/3 James McKenzie <jjmckenzie51(a)earthlink.net>:
> Can you please use standard compression programs with standard extensions.
>
> Your file extension, .bin will not work here.

Although application/octet-stream might not be the best content type,
it's just text.

msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)

[Rob Shearman]

2009/3/3 Henri Verbeet <hverbeet(a)gmail.com>:
> 2009/3/3 James McKenzie <jjmckenzie51(a)earthlink.net>:
> > Can you please use standard compression programs with standard extensions.
> >
> > Your file extension, .bin will not work here.
>
> Although application/octet-stream might not be the best content type,
> it's just text.

In order for patches to be easily viewed in most email clients and
hence reviewed, they should be sent with a content type of text/*
(e.g. text/plain), regardless of whether the content is text and
compressed text.

-- 
Rob Shearman