audio glitch patch by mike hearn
I'm trying to implement this patch: http://wiki.winehq.org/Implement_SetThreadPriority by Mike Hearn which will enable wine to work without all the nasty audio glitches when using alsa. However hunk 1 fails on configure.ac as the patch hasn't been updated to latest wine. Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever. If there are any details (does wineserver/wine* has to be setuid root? do i need any special settings in winecfg, will it work with sudo or do i have to be root,etc etc) I would like to get informed of them also as it will probably take me days to figure it out on my own <:) some guy rediffed(whatever that means) it here: http://bbs.archlinux.org/viewtopic.php?t=27529&highlight= but it doesn't seem to work. Thanks for all the help. I'm asking here as Mike is too busy to fix it, but he says it should be an easy fix. -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
On Wednesday 06 December 2006 14:48, kfs1(a)online.no wrote:
I'm trying to implement this patch: http://wiki.winehq.org/Implement_SetThreadPriority by Mike Hearn which will enable wine to work without all the nasty audio glitches when using alsa. However hunk 1 fails on configure.ac as the patch hasn't been updated to latest wine.
Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever.
I have a stripped down version of the patch that doesn't require any configure changes and should apply fine to the latest wine. It's designed for systems that have RLIMIT_RTPRIO (Linux kernel 2.6.13 and up) and works as long as the user can set real-time priority for processes (an updated/modified PAM can set such permissions for users; realtime-lsm may work too, but I don't have any experience with it). Running as root/suid with this is NOT recommended as it makes no provisions for it.. it doesn't attempt to drop permissions, so whatever you run Wine as, the whole program will have the same permissions.
On Thu, 07 Dec 2006 06:21:59 +0100, Chris Robinson <chris.kcat(a)gmail.com> wrote:
On Wednesday 06 December 2006 14:48, kfs1(a)online.no wrote:
I'm trying to implement this patch: http://wiki.winehq.org/Implement_SetThreadPriority by Mike Hearn which will enable wine to work without all the nasty audio glitches when using alsa. However hunk 1 fails on configure.ac as the patch hasn't been updated to latest wine.
Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever.
I have a stripped down version of the patch that doesn't require any configure changes and should apply fine to the latest wine. It's designed for systems that have RLIMIT_RTPRIO (Linux kernel 2.6.13 and up) and works as long as the user can set real-time priority for processes (an updated/modified PAM can set such permissions for users; realtime-lsm may work too, but I don't have any experience with it). Running as root/suid with this is NOT recommended as it makes no provisions for it.. it doesn't attempt to drop permissions, so whatever you run Wine as, the whole program will have the same permissions.
Ahhh perfect! Send it over! How would i run it as pam though? And an additional question: Would this speedup alsa too? as I finally got alsa's oss emulation to work with wine which is much much faster :S -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
On Wednesday 06 December 2006 22:52, you wrote:
Ahhh perfect! Send it over! How would i run it as pam though? And an additional question: Would this speedup alsa too? as I finally got alsa's oss emulation to work with wine which is much much faster :S
PAM is a sysadmin tool that can (among other things) control resource limits for various users/groups. I'm not exactly sure which version, but later versions allow you to set rtprio limits for users (not to be confused with 'priority', which isn't what you want). An example line for /etc/security/limits.conf would be: <name> - rtprio 1 The patch currently only utilizes a value of 1, so you don't need anything higher. Also, make sure /etc/pam.d/login has this: session required /lib/security/pam_limits.so After making the changes, restart the user login session. Assuming all went well, applications can now set a real-time priority level of 1, if run by the named user/group. Then apply this simple patch to Wine: http://kcat.strangesoft.net/wine_thread_prio.diff (~2.5K) ..rebuild, and enjoy. :)
WOOOW!!! Greate result, why isnt this patch in main tree? Mirek Chris Robinson napsal(a):
On Wednesday 06 December 2006 22:52, you wrote:
Ahhh perfect! Send it over! How would i run it as pam though? And an additional question: Would this speedup alsa too? as I finally got alsa's oss emulation to work with wine which is much much faster :S
PAM is a sysadmin tool that can (among other things) control resource limits for various users/groups. I'm not exactly sure which version, but later versions allow you to set rtprio limits for users (not to be confused with 'priority', which isn't what you want). An example line for /etc/security/limits.conf would be:
<name> - rtprio 1
The patch currently only utilizes a value of 1, so you don't need anything higher. Also, make sure /etc/pam.d/login has this:
session required /lib/security/pam_limits.so
After making the changes, restart the user login session. Assuming all went well, applications can now set a real-time priority level of 1, if run by the named user/group. Then apply this simple patch to Wine:
http://kcat.strangesoft.net/wine_thread_prio.diff (~2.5K)
..rebuild, and enjoy. :)
On Thu, 07 Dec 2006 15:27:24 +0100, Marcus Meissner <meissner(a)suse.de> wrote:
On Thu, Dec 07, 2006 at 02:23:20PM +0100, Mirek wrote:
WOOOW!!! Greate result, why isnt this patch in main tree?
Because users usually do not get these root rights.
Well actually most 'users' would get these rights as most users of linux are the administrators themselves!
And the ALSA driver should be fixed properly. :(
probably...
Ciao, Marcus
-- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Am Donnerstag 07 Dezember 2006 15:46 schrieb kfs1(a)online.no:
Well actually most 'users' would get these rights as most users of linux are the administrators themselves! But you should *never* work as root, and *never ever* run wine as root, and *even more never ever* run most likely cracked games as root(due to the lack of copy protection support in wine)
Stefan Dösinger wrote:
Am Donnerstag 07 Dezember 2006 15:46 schrieb kfs1(a)online.no:
Well actually most 'users' would get these rights as most users of linux are the administrators themselves!
But you should *never* work as root, and *never ever* run wine as root, and *even more never ever* run most likely cracked games as root(due to the lack of copy protection support in wine)
------------------------------------------------------------------------ The point is not that most people would run as root; it was that most people would have the ability to grant themselves realtime privileges. And, frankly, I think most people who would benefit from this patch would be quite willing to accept a slight possibility of locking up their systems if it meant they could play games with clean audio. I know I certainly would.
--mmebane
On Thu, 07 Dec 2006 19:13:00 +0100, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Am Donnerstag 07 Dezember 2006 15:46 schrieb kfs1(a)online.no:
Well actually most 'users' would get these rights as most users of linux are the administrators themselves! But you should *never* work as root, and *never ever* run wine as root, and *even more never ever* run most likely cracked games as root(due to the lack of copy protection support in wine)
But this isn't root is it? This is using the rtprio support in linux kernel... -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
kfs1(a)online.no wrote:
Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever.
I can give you my dsound/alsa patches if you want. I've changed the dsound code to use 'native' alsa buffers/mixer instead of the one implemented in dsound and I don't have any problems at all with bad sound anymore. tom
Am Donnerstag 07 Dezember 2006 22:20 schrieb Tomas Carnecky:
kfs1(a)online.no wrote:
Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever.
I can give you my dsound/alsa patches if you want. I've changed the dsound code to use 'native' alsa buffers/mixer instead of the one implemented in dsound and I don't have any problems at all with bad sound anymore. Are you going to work on getting this committed into wine git?
Stefan Dösinger wrote:
Am Donnerstag 07 Dezember 2006 22:20 schrieb Tomas Carnecky:
I can give you my dsound/alsa patches if you want. I've changed the dsound code to use 'native' alsa buffers/mixer instead of the one implemented in dsound and I don't have any problems at all with bad sound anymore. Are you going to work on getting this committed into wine git?
Unfortunately that would require too much work, well, more or less a rewrite of the current dsound core and some drivers. And I don't have the time or patience for that. But of course, if someone decides to pick my patches up, I'll give him every support I can. tom
On Thursday December 7 2006 23:30, Tomas Carnecky wrote:
Stefan Dösinger wrote:
Am Donnerstag 07 Dezember 2006 22:20 schrieb Tomas Carnecky:
I can give you my dsound/alsa patches if you want. I've changed the dsound code to use 'native' alsa buffers/mixer instead of the one implemented in dsound and I don't have any problems at all with bad sound anymore.
Are you going to work on getting this committed into wine git?
Unfortunately that would require too much work, well, more or less a rewrite of the current dsound core and some drivers. And I don't have the time or patience for that. But of course, if someone decides to pick my patches up, I'll give him every support I can.
tom
If you want that someone help you with your patches than it is good idea to post them here (at wine-devel) as attachments. Because without seeing patches it is difficult to say can one do the work or not.
On Thursday December 7 2006 21:20, you wrote:
kfs1(a)online.no wrote:
Can anyone help me get this baby compiled as i want to play my games without the nasty audio glitches and don't care if i have to be root/sudo/whatever.
I can give you my dsound/alsa patches if you want. I've changed the dsound code to use 'native' alsa buffers/mixer instead of the one implemented in dsound and I don't have any problems at all with bad sound anymore.
I very appreciate if you send me your patchs too. Thanks!
For your convenience.. http://dbservice.com/ftpdir/tom/dsound-alsa.patch You have to enable 'ALSA' and full hardware acceleration, no emulation. Don't know if it works with other applications than World of Warcraft though... Note that this patch is _full_ of non-important changes that could be removed, I just didn't come along doing it as I always just 'git-fetch' and 'git-rebase origin'.. tom
Hi, i tried it with few other applications, it is not working well. Mirek Tomas Carnecky napsal(a):
For your convenience.. http://dbservice.com/ftpdir/tom/dsound-alsa.patch
You have to enable 'ALSA' and full hardware acceleration, no emulation. Don't know if it works with other applications than World of Warcraft though...
Note that this patch is _full_ of non-important changes that could be removed, I just didn't come along doing it as I always just 'git-fetch' and 'git-rebase origin'..
tom
participants (8)
-
Chris Robinson -
kfs1＠online.no -
L. Rahyen -
Marcus Meissner -
Mirek -
Mitchell Mebane -
Stefan Dösinger -
Tomas Carnecky