Re: [4/4] shdocvw: Implement basic back/forward history support (resend)

[Jacek Caban]

Hi Owen,

On 1/18/11 1:35 AM, Owen Rudge wrote:
> This resend removes a superfluous function. Parts 1-3 are unaffected.
>
> ---
>  dlls/shdocvw/dochost.c    |    1 +
>  dlls/shdocvw/ie.c         |    6 +---
>  dlls/shdocvw/iexplore.c   |   12 +++++++-
>  dlls/shdocvw/navigate.c   |   66 
> +++++++++++++++++++++++++++++++++++++++++++++
>  dlls/shdocvw/resource.h   |    2 +
>  dlls/shdocvw/shdocvw.h    |   12 ++++++++
>  dlls/shdocvw/webbrowser.c |    6 +---
>  7 files changed, 95 insertions(+), 10 deletions(-)

First of all, tests please.

Navigation history is more complicated than your approach. The most 
important thing is that documents reporting DOCHOST_DOCCANNAVIGATE are 
handling navigation themselves. HTMLDocument, about which we care the 
most, is such document. It means that most of the work should be done in 
mshtml and shdocvw should only notify mshtml about navigation back/forward.

diff --git a/dlls/shdocvw/iexplore.c b/dlls/shdocvw/iexplore.c
index 3b652cb..cac04a3 100644
--- a/dlls/shdocvw/iexplore.c
+++ b/dlls/shdocvw/iexplore.c

This part is fine can be a separated patch.

Jacek