Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

[DavidL]

Hi,

I recently submitted a patch which had at least one whitespace formatting
issue. Looking over it, I found one on line 518, a bracket in the wrong
place. Is there an easy way for me to check if there are more formatting
issues before resubmitting? Or should I simply resubmit?

Thanks!
David

On Fri, Jun 10, 2016 at 7:06 AM, Marvin <testbot(a)winehq.org> wrote:
> Thank you for your contribution to Wine!
>
> This is an automated notification to let you know that your patch has
> been reviewed and its status set to "Formatting".
>
> This means that there are some formatting issues with your
> patch. Either the author's full name, email address, or Signed-off-by
> headers are missing, indentation is messed up (usually from editing
> with a non-standard tab size), or there are gratuitous formatting
> changes to the code. You need to resend a fixed patch.
>
> If you do not understand the reason for this status, disagree with our
> assessment, or are simply not sure how to proceed next, please ask for
> clarification by replying to this email.

[1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

[Indrek Altpere]

Probably the main thing was “indentation is messed up (usually from editing with a non-standard tab size)”

In your patch, some lines have space indentation, others have tabs. Using spaces is the correct option.

 

Regards,

Indrek

 

From: wine-devel [mailto:wine-devel-bounces(a)winehq.org] On Behalf Of DavidL
Sent: Friday, June 10, 2016 9:42 PM
To: wine-devel(a)winehq.org
Subject: Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

 

Hi, 

 

I recently submitted a patch which had at least one whitespace formatting issue. Looking over it, I found one on line 518, a bracket in the wrong place. Is there an easy way for me to check if there are more formatting issues before resubmitting? Or should I simply resubmit?

 

Thanks!

David

 

On Fri, Jun 10, 2016 at 7:06 AM, Marvin <testbot(a)winehq.org <mailto:testbot(a)winehq.org> > wrote:

Thank you for your contribution to Wine!

This is an automated notification to let you know that your patch has
been reviewed and its status set to "Formatting".

This means that there are some formatting issues with your
patch. Either the author's full name, email address, or Signed-off-by
headers are missing, indentation is messed up (usually from editing
with a non-standard tab size), or there are gratuitous formatting
changes to the code. You need to resend a fixed patch.

If you do not understand the reason for this status, disagree with our
assessment, or are simply not sure how to proceed next, please ask for
clarification by replying to this email.