Re: [PATCH 1/5] wined3d: Don't print FIXMEs for misaligned surface maps.
On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote:
- FIXME("Partial block lock with %s\n", debug_d3dpool(surface->resource.pool)); I added this fixme because we have to tests for the offset that is returned in this case. Do you have an application that triggers this fixme, or do you want to suppress the fixmes in the tests?
On Tuesday 08 November 2011 21:33:39 Stefan Dösinger wrote:
I added this fixme because we have to tests for the offset that is returned in this case. Sorry, typo: I meant "because we have no tests".
On 8 November 2011 21:33, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote:
- FIXME("Partial block lock with %s\n", debug_d3dpool(surface->resource.pool)); I added this fixme because we have to tests for the offset that is returned in this case. Do you have an application that triggers this fixme, or do you want to suppress the fixmes in the tests?
Mostly because of the spam this introduces in the tests. Arguably this is something the tests you added should have covered, but I don't think it's a particularly interesting case and what we currently return is probably the only offset that makes some kind of sense anyway.
On Tuesday 08 November 2011 23:23:23 Henri Verbeet wrote:
On 8 November 2011 21:33, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote:
- FIXME("Partial block lock with %s\n", debug_d3dpool(surface->resource.pool));
I added this fixme because we have to tests for the offset that is returned in this case. Do you have an application that triggers this fixme, or do you want to suppress the fixmes in the tests?
Mostly because of the spam this introduces in the tests. Ok.
participants (2)
-
Henri Verbeet -
Stefan Dösinger