[PATCH] dxgi: Fake success in dxgi_adapter_RegisterVideoMemoryBudgetChangeNotificationEvent

[Fabian Maurer]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51665
Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>
---
 dlls/dxgi/adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dxgi/adapter.c b/dlls/dxgi/adapter.c
index e38fef5fa4f..987b89c4a88 100644
--- a/dlls/dxgi/adapter.c
+++ b/dlls/dxgi/adapter.c
@@ -350,7 +350,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_RegisterVideoMemoryBudgetChangeNot
 {
     FIXME("iface %p, event %p, cookie %p stub!\n", iface, event, cookie);

-    return E_NOTIMPL;
+    return S_OK;
 }

 static void STDMETHODCALLTYPE dxgi_adapter_UnregisterVideoMemoryBudgetChangeNotification(
--
2.35.1

[Henri Verbeet]

On Sat, 12 Feb 2022 at 23:41, Fabian Maurer <dark.shadow4(a)web.de> wrote:
> @@ -350,7 +350,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_RegisterVideoMemoryBudgetChangeNot
>  {
>      FIXME("iface %p, event %p, cookie %p stub!\n", iface, event, cookie);
>
> -    return E_NOTIMPL;
> +    return S_OK;
>  }

I think we should just implement this. Conor sent a patch series for
this some time ago; that didn't make it in at the time, but that could
be rebased, and the functionality is likely a bit easier to implement
these days.

[Fabian Maurer]

> I think we should just implement this. Conor sent a patch series for
> this some time ago; that didn't make it in at the time, but that could
> be rebased, and the functionality is likely a bit easier to implement
> these days.

Is there any news on this? It's been a while, and the program is still broken.
Don't we want at least a workaround until the functionality is properly
implemented?

Regards,
Fabian Maurer

[Conor McCarthy]

On Sat, Apr 23, 2022 at 9:05 PM Fabian Maurer <dark.shadow4(a)web.de> wrote:
> Is there any news on this? It's been a while, and the program is still
> broken.
> Don't we want at least a workaround until the functionality is properly
> implemented?

I will rebase those old patches and see if it can be simplified.