[PATCH] netapi32/tests: Print NetWkstaTransportEnum error code on test failure

[Alex Henrie]

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
---
This will help us figure out why this test fails intermittently on
Windows 10.
---
 dlls/netapi32/tests/wksta.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/netapi32/tests/wksta.c b/dlls/netapi32/tests/wksta.c
index ee3004e17c..418a1ad626 100644
--- a/dlls/netapi32/tests/wksta.c
+++ b/dlls/netapi32/tests/wksta.c
@@ -168,7 +168,8 @@ static void run_wkstatransportenum_tests(void)
     /* 4th check: is param 6 passed? */
     apiReturn = pNetWkstaTransportEnum(NULL, 0, &bufPtr, MAX_PREFERRED_LENGTH,
         &entriesRead, NULL, NULL);
-    ok(apiReturn == RPC_X_NULL_REF_POINTER, "null pointer\n");
+    ok(apiReturn == RPC_X_NULL_REF_POINTER,
+       "NetWkstaTransportEnum returned %d\n", apiReturn);
 
     /* final check: valid return, actually get data back */
     apiReturn = pNetWkstaTransportEnum(NULL, 0, &bufPtr, MAX_PREFERRED_LENGTH,
-- 
2.15.1

[Dmitry Timoshkov]

Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> This will help us figure out why this test fails intermittently on
> Windows 10.
> ...
> -    ok(apiReturn == RPC_X_NULL_REF_POINTER, "null pointer\n");
> +    ok(apiReturn == RPC_X_NULL_REF_POINTER,
> +       "NetWkstaTransportEnum returned %d\n", apiReturn);

Since this is basically an NT status code it would help better when
being printed in hex.

-- 
Dmitry.

[Alex Henrie]

2017-12-19 23:08 GMT-07:00 Dmitry Timoshkov <dmitry(a)baikal.ru>:
> Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > This will help us figure out why this test fails intermittently on
> > Windows 10.
> > ...
> > -    ok(apiReturn == RPC_X_NULL_REF_POINTER, "null pointer\n");
> > +    ok(apiReturn == RPC_X_NULL_REF_POINTER,
> > +       "NetWkstaTransportEnum returned %d\n", apiReturn);
>
> Since this is basically an NT status code it would help better when
> being printed in hex.

All of the other error messages in this function print apiReturn in
decimal, and almost all of the expected return values are pre-NT error
codes. It might still be helpful to print apiReturn in hex, but it's
not a clear improvement to me, and we'd want to change all the error
messages and not just this one.

-Alex