Long translation patch
Hello, Long time no see :D I've been updating the translation of Wine to Brazilian Portuguese for the last couple of days. I have checked and made extensive tests (I opened the programs, used XN Resource Editor on the resources of the dlls and made a fast review of the diff file). It turns out the patch is very large (around 6500 lines). Sorry if this is a lame question, but I guess I'll need to break it in 15 patches or so, right? Should I send all patches in the same day? I don't want to give the patch reviewers a headache :) Cheers, Gustavo
Gustavo Henrique Milaré <gugamilare(a)gmail.com> writes:
It turns out the patch is very large (around 6500 lines). Sorry if this is a lame question, but I guess I'll need to break it in 15 patches or so, right? Should I send all patches in the same day? I don't want to give the patch reviewers a headache :)
If it only touches the po file, a single patch is fine. Just make sure it's relative to the latest git on the day you send it, otherwise some chunks would probably fail to apply. -- Alexandre Julliard julliard(a)winehq.org
Thank you for the heads up, Julliard :) I've sent the patch and it was applied, but there is one small problem. After pulling the git repo, I realized that there are still two texts marked as fuzzy (lines 589 and 595). It is funny, because the patch I sent explicitly removed the two fuzzy annotations. Gustavo Em 13 de janeiro de 2012 07:44, Alexandre Julliard <julliard(a)winehq.org>escreveu:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> writes:
It turns out the patch is very large (around 6500 lines). Sorry if this is a lame question, but I guess I'll need to break it in 15 patches or so, right? Should I send all patches in the same day? I don't want to give the patch reviewers a headache :)
If it only touches the po file, a single patch is fine. Just make sure it's relative to the latest git on the day you send it, otherwise some chunks would probably fail to apply.
-- Alexandre Julliard julliard(a)winehq.org
2012/1/13 Gustavo Henrique Milaré <gugamilare(a)gmail.com>:
Thank you for the heads up, Julliard :)
I've sent the patch and it was applied, but there is one small problem. After pulling the git repo, I realized that there are still two texts marked as fuzzy (lines 589 and 595). It is funny, because the patch I sent explicitly removed the two fuzzy annotations.
Sometimes fuzzy keywords are added, e.g. when an English string is fixed. To see other errors (not necessarily fuzzy strings), you can check François Gouget's tool at http://fgouget.free.fr/wine-po/ Frédéric NB: BTW François, it would be nice it that po errors page included the "run" date
Am 13.01.2012 19:50, schrieb Frédéric Delanoy:
NB: BTW François, it would be nice it that po errors page included the "run" date
you can at least see the git sha1 in e.g. http://fgouget.free.fr/wine-po/fr-errors.html (by moving the mouse over the links) much better would be an integration into transl, i'd volunteer for it -- Best Regards, André Hentschel
On Fri, 13 Jan 2012, Frédéric Delanoy wrote: [...]
Sometimes fuzzy keywords are added, e.g. when an English string is fixed. To see other errors (not necessarily fuzzy strings), you can check François Gouget's tool at http://fgouget.free.fr/wine-po/
Frédéric
NB: BTW François, it would be nice it that po errors page included the "run" date
I added the date at the bottom of the page. The Wine commit id that the tests ran against is also indicated in the title now. I also added a files to ignore obvious false positives (well, still requiring some help from Wikipedia) for many languages. Finally I added totals for the inconsistencies, spelling errors and false positives. The only use is to provide a simple to track 'progress meter': we currently have 3964 inconsistencies and 855 false positives. On the spelling fronts there are 6036 potential spelling errors and 772 extra words in the dictionaries. More importantly I should probably add more documentation on how to tell the system to ignore the various types of false positives (i.e. beyond email me). At least now most languages have some sample files. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.
participants (5)
-
Alexandre Julliard -
André Hentschel -
Francois Gouget -
Frédéric Delanoy -
Gustavo Henrique Milaré