Re: DDraw: Better flag handling in SetCooperativeLevel

[Stefan Dösinger]

Hello,
> > Alexandre, any reason why this patch (plus the other about the reference
> > counting) were not applied ? If you were waiting for some DDraw 'guru' to
> > give his blessing, they both look OK to me :-)
> I think the reference counting one is suspect, there should be some
> object that holds the reference, we shouldn't just increment it for no
> reason.

> For the other one, the tests fail here:

> fixme:ddraw:Main_DirectDraw_SetCooperativeLevel  
(0x7fdc90d0)->(0x10022,00000008)
> fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x7fdc90d0)->(0x10022,00000080)
> cooplevels.c:88: Test failed: SetCooperativeLevel(DDSCL_SETFOCUSWINDOW) 
returned: 80070057
> <snip>
> cooplevels.c:98: Test failed: SetCooperativeLevel(DDSCL_NORMAL | 
DDSCL_SETFOCUSWINDOW) returned: 0
It looks like the patch wasn't applied correctly. The main purpose of this 
patch is to make SetCooperativeLevel(hwnd, DDSCL_SETFOCUSWINDOW) work.
The tests run fine on my wine installation and on Win2K and Win95(with DirectX 
8)

I'll send a patch against CVS from today to wine-patches.

Stefan