Re: cmd: Remove a pointless linefeed in an error message.

[Julian Rüger]

Sorry for nagging ;)

Wasn't the convention to assume an 80-character wide terminal?
This line would wrap, then.

So the linefeed is not totally pointless here. Please correct me, if I'm
mistaken.

Best regards,
Julian

Am Mittwoch, den 03.04.2013, 16:07 +0200 schrieb Francois Gouget:
> ---
>  programs/cmd/cmd.rc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/programs/cmd/cmd.rc b/programs/cmd/cmd.rc
> index c3cdb52..d464cab 100644
> --- a/programs/cmd/cmd.rc
> +++ b/programs/cmd/cmd.rc
> @@ -360,5 +360,5 @@ Enter HELP <command> for further information on any of the above commands.\n"
>    WCMD_NOOPERAND, "Expected an operand.\n"
>    WCMD_NOOPERATOR, "Expected an operator.\n"
>    WCMD_BADPAREN, "Mismatch in parentheses.\n"
> -  WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12),\n hexadecimal (0x34) or octal (056).\n"
> +  WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12), hexadecimal (0x34) or octal (056).\n"
>  }

cmd: Remove a pointless linefeed in an error message.

[Francois Gouget]

On Wed, 3 Apr 2013, Julian Rüger wrote:
> Sorry for nagging ;)
>
> Wasn't the convention to assume an 80-character wide terminal?
> This line would wrap, then.
>
> So the linefeed is not totally pointless here. Please correct me, if I'm
> mistaken.

Either we wrap it manually assuming a terminal width that may be wrong, 
or we let it wrap automatically, but possibly not on a word boundary.
I don't think the first option is particularly better.

In fact the option I prefer is the third one: using FormatMessage() to 
wrap the message on a word boundary to the terminal width. But it may 
well be overkill too.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                           La terre est une bêta...