CPP Check Runs Clean but found these Style Issues on Latest Git...
Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore them from now on. Here they are: File Line Style Problem dlls/dnsapi/ns_name.c 1 The function dns_ns_name_skip' is never used The function dns_ns_name_uncompress' is never used dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used The function EMFDRV_OffsetViewportOrg' is never used The function EMFDRV_OffsetWindowOrg' is never used The function EMFDRV_ScaleViewportExt' is never used The function EMFDRV_ScaleWindowExt' is never used The function EMFDRV_SetMapMode' is never used The function EMFDRV_SetViewportExt' is never used The function EMFDRV_SetViewportOrg' is never used The function EMFDRV_SetWindowExt' is never used The function EMFDRV_SetWindowOrg' is never used The function EMFDRV_SetWorldTransform' is never used dlls/gdi32/mfdrv/dc.c 1 The function MFDRV_AbortPath' is never used The function MFDRV_BeginPath' is never used The function MFDRV_CloseFigure' is never used The function MFDRV_EndPath' is never used The function MFDRV_ExcludeClipRect' is never used The function MFDRV_FillPath' is never used The function MFDRV_FlattenPath' is never used The function MFDRV_IntersectClipRect' is never used The function MFDRV_OffsetClipRgn' is never used The function MFDRV_RestoreDC' is never used The function MFDRV_SaveDC' is never used The function MFDRV_SelectClipPath' is never used The function MFDRV_SetBkMode' is never used The function MFDRV_SetMapperFlags' is never used The function MFDRV_SetPolyFillMode' is never used The function MFDRV_SetRelAbs' is never used The function MFDRV_SetROP2' is never used The function MFDRV_SetStretchBltMode' is never used The function MFDRV_SetTextAlign' is never used The function MFDRV_SetTextCharacterExtra' is never used The function MFDRV_SetTextJustification' is never used The function MFDRV_StrokeAndFillPath' is never used The function MFDRV_StrokePath' is never used The function MFDRV_WidenPath' is never used dlls/rpcrt4/rpc_transport.c 1 The function RpcNetworkIsProtseqValidA' is never used dlls/rpcrt4/rpc_transport.c 700 The scope of the variable b_handle can be reduced dlls/wininet/cookie.c 1 The function IsDomainLegalCookieDomainW' is never used dlls/wininet/cookie.c 225 The scope of the variable len can be reduced dlls/wininet/dialogs.c 132 The scope of the variable q can be reduced dlls/wininet/dialogs.c 181 The scope of the variable u_len can be reduced dlls/wininet/ftp.c 359 The scope of the variable nResCode can be reduced dlls/wininet/ftp.c 1261 The scope of the variable retval can be reduced dlls/wininet/http.c 1 The function IsHostInProxyBypassList' is never used dlls/wininet/http.c 750 The scope of the variable userlen can be reduced dlls/wininet/http.c 751 The scope of the variable passlen can be reduced dlls/wininet/http.c 3355 The scope of the variable lpszCookies can be reduced dlls/wininet/http.c 3365 The scope of the variable cnt can be reduced dlls/wininet/http.c 3868 The scope of the variable headerlen can be reduced dlls/wininet/internet.c 1 The function DllMain' is never used dlls/wininet/internet.c 1464 The scope of the variable lpszNetLoc can be reduced dlls/wininet/internet.c 2712 The scope of the variable len can be reduced dlls/wininet/internet.c 2714 The scope of the variable status can be reduced dlls/wininet/urlcache.c 1 The function CreateUrlCacheContainerA' is never used The function CreateUrlCacheContainerW' is never used The function DeleteUrlCacheContainerA' is never used The function DeleteUrlCacheContainerW' is never used The function FindFirstUrlCacheContainerA' is never used The function FindFirstUrlCacheContainerW' is never used The function FindNextUrlCacheContainerA' is never used The function FindNextUrlCacheContainerW' is never used The function FreeUrlCacheSpaceA' is never used The function FreeUrlCacheSpaceW' is never used The function RegisterUrlCacheNotification' is never used dlls/wininet/urlcache.c 155 struct or union member _URLCACHE_HEADER::dwBlocksInUse' is never used dlls/wininet/urlcache.c 159 struct or union member _URLCACHE_HEADER::dwUnknown4' is never used dlls/wininet/urlcache.c 160 struct or union member _URLCACHE_HEADER::dwUnknown5' is never used dlls/wininet/urlcache.c 161 struct or union member _URLCACHE_HEADER::dwUnknown6' is never used dlls/wininet/urlcache.c 164 struct or union member _URLCACHE_HEADER::Unknown8' is never used dlls/wininet/urlcache.c 673 The scope of the variable error can be reduced dlls/wininet/urlcache.c 2190 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2438 The scope of the variable len can be reduced dlls/wininet/urlcache.c 2731 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2733 The scope of the variable len can be reduced libs/port/spawn.c 39 The scope of the variable wret can be reduced libs/wpp/ppl.yy.c 393 struct or union member yy_trans_info::yy_verify' is never used libs/wpp/ppl.yy.c 394 struct or union member yy_trans_info::yy_nxt' is never used libs/wpp/ppl.yy.c 3942 The scope of the variable new_alloc can be reduced libs/wpp/ppl.yy.c 4152 The scope of the variable new_alloc can be reduced libs/wpp/ppy.tab.c 265 struct or union member YYSTYPE::iptr' is never used libs/wpp/preproc.c 321 The scope of the variable len can be reduced loader/preloader.c 1 The function __bb_init_func' is never used The function __stack_chk_fail_local' is never used The function __stack_chk_fail' is never used The function wld_start' is never used tools/widl/client.c 80 The scope of the variable method_count can be reduced tools/widl/header.c 717 The scope of the variable first_iface can be reduced tools/widl/header.c 803 The scope of the variable first_iface can be reduced tools/widl/parser.tab.c 432 struct or union member YYSTYPE::array_dims' is never used tools/widl/parser.tab.c 439 struct or union member YYSTYPE::func_list' is never used tools/widl/parser.yy.c 388 struct or union member yy_trans_info::yy_verify' is never used tools/widl/parser.yy.c 389 struct or union member yy_trans_info::yy_nxt' is never used tools/widl/proxy.c 591 The scope of the variable first_func can be reduced tools/winebuild/import.c 227 The scope of the variable i can be reduced tools/winebuild/parser.c 913 The scope of the variable i can be reduced tools/winebuild/res32.c 281 The scope of the variable i can be reduced tools/winebuild/res32.c 600 The scope of the variable err can be reduced Chris
On 1/17/2010 21:50, chris ahrendt wrote:
Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore them from now on. Here they are:
Really unused functions are reported as compiler warnings. So I don't see how this could be useful. Regarding variable scope, it's better to reduce it of course, but it most likely won't be accepted as separate patch.
participants (2)
-
chris ahrendt -
Nikolay Sivov