Re: Listview: Implemented Get/SetToolTips functions (rewrite)

[Dimitrie O. Paun]

On May 10, 2003 03:51 am, BiGgUn wrote:
> Hi,
> > > +static HWND LISTVIEW_SetToolTips( LISTVIEW_INFO *, HWND);
> >
> > I don't think you need these here.
>
> Dimitry, should i inline LISTVIEW_SetToolTips also ?

Hey, my name is Dimitrie or Dimi :)
> In this patch, LISTVIEW_SetToolTips is not inlined.

No, that's fine, setters are not inlined currently.
> static INT LISTVIEW_GetTopIndex(LISTVIEW_INFO *);
>  static BOOL LISTVIEW_EnsureVisible(LISTVIEW_INFO *, INT, BOOL);
>  static HWND CreateEditLabelT(LISTVIEW_INFO *, LPCWSTR, DWORD, INT, INT, INT, INT, BOOL);
> +static HWND LISTVIEW_SetToolTips( LISTVIEW_INFO *, HWND);

Why do you need this prototype here? I don't think it's needed, you don't
use the function before the definition.
> +static HWND LISTVIEW_SetToolTips( LISTVIEW_INFO *infoPtr, HWND hwndNewToolTip)
> +{
> + HWND hwndOldToolTip = infoPtr->hwndToolTip;

Indentation seems to be hosed here, no?
> +    infoPtr->hwndToolTip = hwndNewToolTip;
> +    return hwndOldToolTip;
> +}
> +
>  /* LISTVIEW_SetUnicodeFormat */
>  /* LISTVIEW_SetWorkAreas */
>
> @@ -7214,7 +7241,7 @@
>                      GetWindowLongW(infoPtr->hwndHeader, GWL_STYLE) | HDS_HIDDEN); 
>      }
>    }
> -
> +

Please avoid such no-op changes, they make the patch longer for no good reason.

I'm kinda picky, right? :)

-- 
Dimi.