Re: [PATCH 3/3] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions. [Try 2]

[Juan Lang]

Hi Rob,

+    file->mode |= st.st_mode & (S_IRWXU|S_IRWXO);

Why "|=" rather than simply "="?
--Juan

[PATCH 3/3] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions. [Try 2]

[Robert Shearman]

Juan Lang wrote:
> Hi Rob,
>
> +    file->mode |= st.st_mode & (S_IRWXU|S_IRWXO);
>
> Why "|=" rather than simply "="?

Good point. I had a reason when I was wrote the code, but it seems like 
there should be no problems with file->mode always being kept up-to-date.

-- 
Rob Shearman