Re: winetest: don't start test programs with STARTUPINFO.wShowWindow = SW_HIDE
Oct. 15, 2006
12:56 a.m.
On Sat, 14 Oct 2006, Mikoaj Zalewski wrote:
> It no one knowns why this option is there then maybe it's safe to remove it?
- si.wShowWindow = SW_HIDE;
- si.dwFlags = STARTF_USESHOWWINDOW;
+ si.dwFlags = 0;
Isn't this an attempt to make it so that running make test does not pop
up windows that grab the focus and do things that prevent you from using
the computer? Though some test do grab the focus and such which I guess
means they're manually changing the state of the window..
--
Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/
1 + e ^ ( i * pi ) = 0
October 2006
4:18 a.m.
New subject: winetest: don't start test programs with STARTUPINFO.wShowWindow = SW_HIDE
"Francois Gouget" <fgouget(a)free.fr> wrote: > On Sat, 14 Oct 2006, Mikoaj Zalewski wrote: > >> It no one knowns why this option is there then maybe it's safe to remove it? > - si.wShowWindow = SW_HIDE; > - si.dwFlags = STARTF_USESHOWWINDOW; > + si.dwFlags = 0; > > Isn't this an attempt to make it so that running make test does not pop > up windows that grab the focus and do things that prevent you from using > the computer? The patch should be applied IMO. That SW_HIDE thing must be the cause why user32 tests fail without a visible reason when running by winetest, the tests must be run on a visible desktop anyway. -- Dmitry.
7102
Age (days ago)
7102
Last active (days ago)
1 comments
2 participants
participants (2)
-
Dmitry Timoshkov -
Francois Gouget