Re: [PATCH 2/3] jscript: Improve Number_toString implementation

[Paul Vriens]

Piotr Caban wrote:
> ---
>  dlls/jscript/number.c     |  113
> ++++++++++++++++++++++++++++++++++++++++++--
>  dlls/jscript/tests/api.js |   50 +++++++++++++++++--
>  2 files changed, 151 insertions(+), 12 deletions(-)
>
> ------------------------------------------------------------------------

Hi Piotr,

These new tests fail on several platforms, see:

http://test.winehq.org/data/tests/jscript:run.html

Could you have a look?

-- 
Cheers,

Paul.

[PATCH 2/3] jscript: Improve Number_toString implementation

[Piotr Caban]

Hi Paul,

Could you rerun the tests with following patch? (error message will be
more verbose).

Thanks,
Piotr

diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js
index 6af9bb8..7b1afe6 100644
--- a/dlls/jscript/tests/api.js
+++ b/dlls/jscript/tests/api.js
@@ -607,7 +607,7 @@ function equals(val, base) {
         num *= Math.pow(base, exp);
     }
 
-    ok(num>val-val/1000 && num<val+val/1000, "equals: num = " + num);
+    ok(num>val-val/1000 && num<val+val/1000, "equals: num = " + num + " val = " + val + " base = " + base + " str = " + str);
 }
 
 ok((10).toString(11) === "a", "(10).toString(11) = " + (10).toString(11));

[PATCH 2/3] jscript: Improve Number_toString implementation

[Paul Vriens]

Piotr Caban wrote:
> Hi Paul,
>
> Could you rerun the tests with following patch? (error message will be
> more verbose).
>
> Thanks,
> Piotr

Hi Piotr,

Win98 results attached.

-- 
Cheers,

Paul.

run.c:311: Test failed: api.js: equals: num = 0 val = 4.565061778886334e-19 base = 3 str = 0.000000000000000000000000000000000(e-37)
run.c:311: Test failed: api.js: equals: num = 0 val = 1e-19 base = 3 str = 0.000000000000000000000000000000000(e-38)
run.c:311: Test failed: api.js: equals: num = 0 val = 4.565061778886334e-19 base = 5 str = 0.00000000000000000000000(e-25)
run.c:311: Test failed: api.js: equals: num = 0 val = 1e-19 base = 5 str = 0.00000000000000000000000(e-26)
run.c:311: Test failed: api.js: equals: num = 0 val = 4.565061778886334e-19 base = 6 str = 0.000000000000000000000(e-22)
run.c:311: Test failed: api.js: equals: num = 0 val = 1e-19 base = 6 str = 0.000000000000000000000(e-23)
run.c:311: Test failed: api.js: equals: num = 0 val = 4.565061778886334e-19 base = 7 str = 0.0000000000000000000(e-20)
run.c:311: Test failed: api.js: equals: num = 0 val = 1e-19 base = 7 str = 0.0000000000000000000(e-21)
run.c:311: Test failed: api.js: equals: num = 0 val = 4.565061778886334e-19 base = 9 str = 0.00000000000000000(e-18)
run.c:311: Test failed: api.js: equals: num = 0 val = 1e-19 base = 9 str = 0.00000000000000000(e-18)
run: 12995 tests executed (0 marked as todo, 10 failures), 0 skipped.