Re: quartz: check hr so we are not incrementing a NULL (coverity 106)

[Dmitry Timoshkov]

"Aric Stewart" <aric(a)codeweavers.com> wrote:
> -    wszPatternString++; /* skip ',' */
> +    if (hr == S_OK)
> +        wszPatternString++; /* skip ',' */
>
> if (hr == S_OK)
>     {

Why not just move it into the below block?

-- 
Dmitry.

quartz: check hr so we are not incrementing a NULL (coverity 106)

[Aric Stewart]

true, that would be cleaner.  I will resubmit.

-aric

Dmitry Timoshkov wrote:
> "Aric Stewart" <aric(a)codeweavers.com> wrote:
> > -    wszPatternString++; /* skip ',' */
> > +    if (hr == S_OK)
> > +        wszPatternString++; /* skip ',' */
> >
> > if (hr == S_OK)
> >     {
>
> Why not just move it into the below block?