December 2023 - Wine-GitLab

[PATCH v11 0/3] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Dec. 11, 2023

Dec. 11, 2023

-- v11: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

[PATCH v2 0/1] MR4659: po: Update Polish translation.
by Bartosz Kosiorek (＠gang65) Dec. 11, 2023

Dec. 11, 2023

-- v2: po: Update Polish translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

3 2

[PATCH v7 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 11, 2023

Dec. 11, 2023

-- v7: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce an 'int64' requirement directive. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

3 8

[PATCH v2 0/1] MR516: tests: Print the failing line numbers when a test fails.
by Petrichor Park (＠petrathekat) Dec. 11, 2023

Dec. 11, 2023

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number that a test fails at. This code was actually written by @hverbeet for my first attempt at fixing this, !499. CC @zfigura -- v2: tests: Print the failing line numbers when a test fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516

3 2

[PATCH v2 0/9] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) Dec. 11, 2023

Dec. 11, 2023

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- v2: bcrypt/tests: Add DH tests. bcrypt: Make sure key_asymmetric_derive_key() returns correct size. bcrypt: Add support for generating DH keys from known parameters. bcrypt: Reject DH keys smaller than 512 bits. bcrypt: Make DH blob size validation more strict in key_import_pair(). bcrypt: Add helpers to create a public/private key pair. bcrypt: Allow or disallow some operations based on whether keys are finalized. bcrypt: Add support for retrieving DH parameters. bcrypt: Add support for setting DH parameters. https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 15

[PATCH 0/1] MR4668: winewayland.drv: Avoid deadlock when determining whether a window is managed.
by Alexandros Frantzis (＠afrantzis) Dec. 11, 2023

Dec. 11, 2023

The is_window_managed function may acquire the (non-recursive) win_data lock internally (is_window_managed->has_owned_popups->is_managed), so do not call it with the win_data lock held. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55995 --- Note: WineX11 also calls `is_window_managed` with win_data locked, but its win_data mutex is recursive. I haven't found a compelling reason to use a recursive win_data mutex in the Wayland driver yet, hence this fix. --- A simple way to reproduce the deadlock is: 1. Run winecfg 2. Go to the "Desktop Integration" tab 3. Click on OK -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4668

2 1

[PATCH 0/4] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) Dec. 11, 2023

Dec. 11, 2023

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

4 7

[PATCH 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font
by Hans Lehnert (＠hanslehnert) Dec. 11, 2023

Dec. 11, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

4 4

[PATCH v2 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 11, 2023

Dec. 11, 2023

-- v2: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 3

[PATCH v3 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 11, 2023

Dec. 11, 2023

-- v3: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 2

[PATCH v2 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 10, 2023

Dec. 10, 2023

-- v2: winegstreamer: In error case don't dereference null pointer (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

2 2

[PATCH 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 10, 2023

Dec. 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

3 5

[PATCH v3 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) Dec. 10, 2023

Dec. 10, 2023

-- v3: gdiplus/test: Add GdipGetEffectParameterSize test. gdiplus: Add GdipGetEffectParameterSize stub and fix GdipDeleteEffect https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

2 4

[PATCH 0/2] MR4628: configure: Enable -Wenum-conversion warnings.
by Jacek Caban (＠jacek) Dec. 10, 2023

Dec. 10, 2023

Clang enables -Wenum-conversion by default. GCC does not, so this makes both configurations more similar. The extra dwrite is for Clang -Wenum-float-conversion warning, which is not enabled by default, but it's enabled when -Wenum-conversion is specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4628

3 3

[PATCH 0/1] MR4667: bcrypt: Initialize variable in all cases (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 10, 2023

Dec. 10, 2023

If both branches are false we would never initialize it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4667

3 2

[PATCH 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 10, 2023

Dec. 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

2 1

[PATCH 0/2] MR4640: jscript: Make the garbage collector thread-wide rather than per-ctx.
by Gabriel Ivăncescu Dec. 10, 2023

Dec. 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4640

2 4

[PATCH v10 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) Dec. 9, 2023

Dec. 9, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v10: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

2 7

[PATCH v5 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 9, 2023

Dec. 9, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- v5: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH 0/1] MR4651: winewayland.drv: Avoid transient deactivation of foreground thread.
by Alexandros Frantzis (＠afrantzis) Dec. 9, 2023

Dec. 9, 2023

When updating the foreground window, even if both the old and new active window belong to the same non-current thread, the win32u code currently explicitly deactivates the old window. This will cause the transient deactivation of the foreground thread which can lead to undesirable side-effects (e.g., some apps may minimize when they become inactive). Until this is fixed in Wine core, use an internal driver message to ensure that we call NtUserSetForegroundWindow from the context of the new foreground window thread, to avoid the problematic behavior. --- Assuming that the aforementioned NtUserSetForegroundWindow behavior is indeed incorrect, this should ideally be addressed in win32u, perhaps along the lines of https://gitlab.winehq.org/wine/wine/-/merge_requests/4593/diffs?commit_id=f…. However, given the time of year (freeze etc), the proposed mitigation is possibly a safer choice at this point for Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4651

4 3

[PATCH v4 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 9, 2023

Dec. 9, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- v4: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH v3 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 9, 2023

Dec. 9, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- v3: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

4 8

[PATCH 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) Dec. 9, 2023

Dec. 9, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

5 7

[PATCH v4 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) Dec. 9, 2023

Dec. 9, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v4: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 4

[PATCH v2 0/4] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 9, 2023

Dec. 9, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- v2: gdiplus: Add GdipSetEffectsParameters implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 5

[PATCH 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 9, 2023

Dec. 9, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH v5 0/1] MR4633: win32u: Fix key state not updating before WH_KEYBOARD hook
by Hans Lehnert (＠hanslehnert) Dec. 9, 2023

Dec. 9, 2023

If a message is removed from the queue with PeekMessage/GetMessage, the key state should get updated before calling the WH_KEYBOARD hooks. -- v5: win32u: Fix key state not updating before WH_KEYBOARD hook https://gitlab.winehq.org/wine/wine/-/merge_requests/4633

3 2

[PATCH v3 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) Dec. 9, 2023

Dec. 9, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v3: gdiplus: Partially implement GdipDrawImageFX. gdiplus/tests: Add GdipDrawImageFX tests except effects or attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

2 5

[PATCH 0/1] MR4659: po: Update Polish translation.
by Bartosz Kosiorek (＠gang65) Dec. 9, 2023

Dec. 9, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

3 2

[PATCH 0/1] MR4657: po: Update Lithuanian translation.
by Aurimas Fišeras Dec. 8, 2023

Dec. 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4657

2 2

Re: [PATCH v2 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu. - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

1 0

Re: [PATCH v4 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

1 0

Re: [PATCH v2 0/1] MR4641: winewayland.drv: Apply surface configuration during Vulkan presentation. - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4641

1 0

Re: [PATCH v10 0/6] MR4484: comctl32: Use selected font to determine default min tab width - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

1 0

Re: [PATCH v2 0/2] MR4649: user32/tests: Add tests for word breaks before punctuation - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4649

1 0

Re: [PATCH v3 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2 - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

1 0

Re: [PATCH v3 0/1] MR4648: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) Dec. 8, 2023

Dec. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4648

1 0

[PATCH 0/5] MR4656: quartz: Implement VMR7 renderless mode.
by Zebediah Figura (＠zfigura) Dec. 8, 2023

Dec. 8, 2023

This isn't all of what Rewrite needs, but it's the large and risky part that would be inappropriate for code freeze. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4656

2 5

[PATCH 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns Dec. 8, 2023

Dec. 8, 2023

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

1 1

[PATCH v3 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo).
by Nikolay Sivov (＠nsivov) Dec. 8, 2023

Dec. 8, 2023

Marking as a draft for now, until !4605 is merged first. -- v3: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

3 3

[PATCH 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu.
by Alex Henrie (＠alexhenrie) Dec. 8, 2023

Dec. 8, 2023

When running `wine explorer.exe /desktop=shell` as a full-screen app, there is no obvious way to close it and return to the Linux desktop. Remedy that problem by adding an "Exit desktop" button to the Start menu in the same place as the "Shut Down" button on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

3 2

[PATCH v9 0/6] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) Dec. 8, 2023

Dec. 8, 2023

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v9: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 8

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect. - closed
by Esme Povirk (＠madewokherd) Dec. 8, 2023

Dec. 8, 2023

This merge request was closed by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

1 0

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) Dec. 8, 2023

Dec. 8, 2023

I agree, there's no reason to essentially inline floorf here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55554

1 0

[PATCH v2 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) Dec. 8, 2023

Dec. 8, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v2: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 7

[PATCH v4 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) Dec. 8, 2023

Dec. 8, 2023

-- v4: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. vkd3d: Update the descriptor `next` index before getting a reference for writing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

2 6

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) Dec. 8, 2023

Dec. 8, 2023

On Thu Dec 7 18:47:06 2023 +0000, Rémi Bernon wrote: > Well, code freeze is tomorrow so I don't intend to do anything soon. > You can submit it in a separate MR if you think it's critical for the > well behaving of the driver, and then @julliard will decide what to do > with it, but I would personally wait until we try to fix these > activation issues. Thanks. As a possibly more freeze-safe alternative, I proposed a mitigation in the driver itself https://gitlab.winehq.org/wine/wine/-/merge_requests/4651 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55533

1 0

[PATCH v2 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2
by Matteo Bruni (＠Mystral) Dec. 8, 2023

Dec. 8, 2023

These are all the patches in this area that I think make sense at this point in the release cycle (i.e. a couple of days before code freeze...) I originally had many more. A few are not really suitable at this time; a couple turned out to not really make a difference or generally not feeling like it would be an improvement overall. Many ended up in the way (or not in the spirit) of what we probably want to do at some point, which is grouping the whole draw state setup data together with the draw itself. Not that I could find the time to explore that yet... -- v2: wined3d: Add a bunch of d3d_perf traces. wined3d: Add a frametime debug channel. wined3d: Increase WINED3D_CS_QUERY_POLL_INTERVAL to 100. wined3d: Sleep when waiting for the CS thread. wined3d: Do a blocking wait for CS commands even when there are active queries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

5 10

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Vlad Zahorodnii (＠zzag) Dec. 8, 2023

Dec. 8, 2023

> I have also seen this with KDE, and my current inclination is to say that this is a compositor problem. Looking at the logs it seems the driver is issuing the proper requests, but the cursor remains visible. Yeah, the wayland log looks okay. ``` [ 858989.759] -> wl_pointer(a)15.set_cursor(172832, nil, 0, 0) [ 858989.762] -> zwp_relative_pointer_manager_v1(a)10.get_relative_pointer(new id zwp_relative_pointer_v1(a)59, wl_pointer(a)15) [ 858990.080] -> wl_compositor(a)4.create_region(new id wl_region(a)57) [ 858990.083] -> wl_region(a)57.add(1280, 720, 0, 0) [ 858990.086] -> zwp_pointer_constraints_v1(a)9.confine_pointer(new id zwp_confined_pointer_v1(a)49, wl_surface(a)3, wl_pointer(a)15, wl_region(a)57, 2) ``` this should work, there's only one pointer enter event and no leave event before. Will check why kwin refuses to hide the cursor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55526

1 0

[PATCH v4 0/1] MR4633: winu32: Fix key state not updating before WH_KEYBOARD hook
by Hans Lehnert (＠hanslehnert) Dec. 8, 2023

Dec. 8, 2023

If a message is removed from the queue with PeekMessage/GetMessage, the key state should get updated before calling the WH_KEYBOARD hooks. -- v4: winu32: Fix key state not updating before WH_KEYBOARD hook https://gitlab.winehq.org/wine/wine/-/merge_requests/4633

3 2